From: Christoph Hellwig <hch@lst.de>
To: "Javali, Nilesh" <Nilesh.Javali@cavium.com>
Cc: Christoph Hellwig <hch@lst.de>,
"QLogic-Storage-Upstream@qlogic.com"
<QLogic-Storage-Upstream@qlogic.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] qla4xxx: switch to pci_alloc_irq_vectors
Date: Tue, 6 Dec 2016 14:55:48 +0100 [thread overview]
Message-ID: <20161206135548.GA20111@lst.de> (raw)
In-Reply-To: <D46C98D7.43136%nilesh.javali@cavium.com>
Hi Nilesh,
> > try_msi:
> > /* Trying MSI */
> >- ret = pci_enable_msi(ha->pdev);
> >+ ret = pci_alloc_irq_vectors(ha->pdev, 1, 1, PCI_IRQ_MSI);
> > if (!ret) {
>
> Since pci_alloc_irq_vectors returns a negative error code upon error,
> This should be if (ret).
Fixes, thanks.
> Similarly, driver load fails here as pci_alloc_irq_vectors returns correct
> num of vectors.
> Hence this should be, if (ret < 0).
Also fixed.
The new version is on it's way.
prev parent reply other threads:[~2016-12-06 13:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 7:15 [PATCH] qla4xxx: switch to pci_alloc_irq_vectors Christoph Hellwig
2016-11-29 16:45 ` Martin K. Petersen
2016-11-30 6:08 ` Javali, Nilesh
2016-11-30 16:52 ` Martin K. Petersen
2016-12-06 11:16 ` Javali, Nilesh
2016-12-06 13:55 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206135548.GA20111@lst.de \
--to=hch@lst.de \
--cc=Nilesh.Javali@cavium.com \
--cc=QLogic-Storage-Upstream@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.