From: Stephen Hemminger <stephen@networkplumber.org>
To: Qiming Yang <qiming.yang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 1/3] net/e1000: optimize Rx/Tx log message level
Date: Tue, 6 Dec 2016 14:41:44 -0800 [thread overview]
Message-ID: <20161206144144.1d68d40b@xeon-e3> (raw)
In-Reply-To: <1480761783-36467-2-git-send-email-qiming.yang@intel.com>
On Sat, 3 Dec 2016 18:43:01 +0800
Qiming Yang <qiming.yang@intel.com> wrote:
>
> +#ifdef RTE_LIBRTE_E1000_DEBUG_RX_FREE
> +#define PMD_RX_FREE_LOG(level, fmt, args...) \
> + RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
> +#else
> +#define PMD_RX_FREE_LOG(level, fmt, args...) do { } while (0)
> +#endif
If you have to copy/paste same code in more than one driver, that
looks like a missing interface. I.e Do not Repeat Yourself.
next prev parent reply other threads:[~2016-12-06 22:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 10:43 [PATCH 0/3] net: optimize Rx/Tx log message level Qiming Yang
2016-12-03 10:43 ` [PATCH 1/3] net/e1000: " Qiming Yang
2016-12-06 22:41 ` Stephen Hemminger [this message]
2016-12-03 10:43 ` [PATCH 2/3] net/i40e: " Qiming Yang
2016-12-03 10:43 ` [PATCH 3/3] net/ixgbe: " Qiming Yang
2016-12-06 10:51 ` [PATCH 0/3] net: " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206144144.1d68d40b@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.