From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/panel: simple: Check against num_timings when setting preferred for timing Date: Tue, 6 Dec 2016 16:52:13 +0100 Message-ID: <20161206155213.GA28946@ulmo.ba.sec> References: <20161024132115.25692-1-wens@csie.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0814391424==" Return-path: Received: from mail-wj0-x243.google.com (mail-wj0-x243.google.com [IPv6:2a00:1450:400c:c01::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1DE4E6E3B1 for ; Tue, 6 Dec 2016 15:52:17 +0000 (UTC) Received: by mail-wj0-x243.google.com with SMTP id j10so17271790wjb.3 for ; Tue, 06 Dec 2016 07:52:17 -0800 (PST) In-Reply-To: <20161024132115.25692-1-wens@csie.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0814391424== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IS0zKkzwUGydFO0o" Content-Disposition: inline --IS0zKkzwUGydFO0o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 24, 2016 at 09:21:15PM +0800, Chen-Yu Tsai wrote: > In the loop on .timings, we should check .num_timings to see if it's the > only mode specified, not .num_modes, which should be used with .modes. >=20 > Fixes: cda553725c92 ("drm/panel: simple: Set appropriate mode type") > Signed-off-by: Chen-Yu Tsai > --- > drivers/gpu/drm/panel/panel-simple.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Thierry --IS0zKkzwUGydFO0o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAABCAAGBQJYRt6tAAoJEN0jrNd/PrOhPXwP/0LF1jQa/efqGnwMEBil8tFb 8KSqz0MgnHTLHt1tR25cHNpZSgadUSJvJ41y32NOwSRLdWxunv0d/XAWcMAqvRTE JMNfS09jrJr76D+xZJbHtduP0C7dH+r9UW1TNBpqNOB0JoJi2cO6S2qAYPwba4uz 6yQVpgB41kHUlU7vhuutw8MiWFWCHis1u+wnZ25hau2lGU5AOAcPCidu2C6TBDRi lbN9EWifvTSEs1R81fPEA4Pl5VsqT/MNa2mHeqAGKNhHbAGrL3oiv3xCbntXSv8V t75z5edWVEtgfLU3gsGFJbBTAZVBe6P9gvcOLz078uEmklriEAgK9buSysAkiffV HlvEQ2cxF+hHLzOUtOfdKkBEh9rK1wXG7I70y5DWT9hibrqiZ7lfM+qvqhF1MwJZ Snw3HgYXx2vEBH1fqpeHgcPdEV75e9CAHwNMDjYJks6JPR7fCPMh6VZBJC1nSmh8 4pdqgBzGgz2yqElI3KOMIKilY9CAj1Zi2YGKolYb9xca7yodF7vpUURpzrWpFCRz BfyhGU0Xv6pnl3Gk+VzisQObSRLwQV4c8yEnmSBqXZ+zeJHAPBsNjdcGikK49Xu/ bnCfad4AiTuEKrplQzCu7GRwcMKHAT76svvBaHT0KG4hUmp3xOFGJmyKcDx5WFXW i2pxDPAy5/wju61+jUOP =aT/o -----END PGP SIGNATURE----- --IS0zKkzwUGydFO0o-- --===============0814391424== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0814391424==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753887AbcLFPwU (ORCPT ); Tue, 6 Dec 2016 10:52:20 -0500 Received: from mail-wj0-f195.google.com ([209.85.210.195]:34485 "EHLO mail-wj0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753748AbcLFPwR (ORCPT ); Tue, 6 Dec 2016 10:52:17 -0500 Date: Tue, 6 Dec 2016 16:52:13 +0100 From: Thierry Reding To: Chen-Yu Tsai Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/panel: simple: Check against num_timings when setting preferred for timing Message-ID: <20161206155213.GA28946@ulmo.ba.sec> References: <20161024132115.25692-1-wens@csie.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IS0zKkzwUGydFO0o" Content-Disposition: inline In-Reply-To: <20161024132115.25692-1-wens@csie.org> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --IS0zKkzwUGydFO0o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 24, 2016 at 09:21:15PM +0800, Chen-Yu Tsai wrote: > In the loop on .timings, we should check .num_timings to see if it's the > only mode specified, not .num_modes, which should be used with .modes. >=20 > Fixes: cda553725c92 ("drm/panel: simple: Set appropriate mode type") > Signed-off-by: Chen-Yu Tsai > --- > drivers/gpu/drm/panel/panel-simple.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Thierry --IS0zKkzwUGydFO0o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAABCAAGBQJYRt6tAAoJEN0jrNd/PrOhPXwP/0LF1jQa/efqGnwMEBil8tFb 8KSqz0MgnHTLHt1tR25cHNpZSgadUSJvJ41y32NOwSRLdWxunv0d/XAWcMAqvRTE JMNfS09jrJr76D+xZJbHtduP0C7dH+r9UW1TNBpqNOB0JoJi2cO6S2qAYPwba4uz 6yQVpgB41kHUlU7vhuutw8MiWFWCHis1u+wnZ25hau2lGU5AOAcPCidu2C6TBDRi lbN9EWifvTSEs1R81fPEA4Pl5VsqT/MNa2mHeqAGKNhHbAGrL3oiv3xCbntXSv8V t75z5edWVEtgfLU3gsGFJbBTAZVBe6P9gvcOLz078uEmklriEAgK9buSysAkiffV HlvEQ2cxF+hHLzOUtOfdKkBEh9rK1wXG7I70y5DWT9hibrqiZ7lfM+qvqhF1MwJZ Snw3HgYXx2vEBH1fqpeHgcPdEV75e9CAHwNMDjYJks6JPR7fCPMh6VZBJC1nSmh8 4pdqgBzGgz2yqElI3KOMIKilY9CAj1Zi2YGKolYb9xca7yodF7vpUURpzrWpFCRz BfyhGU0Xv6pnl3Gk+VzisQObSRLwQV4c8yEnmSBqXZ+zeJHAPBsNjdcGikK49Xu/ bnCfad4AiTuEKrplQzCu7GRwcMKHAT76svvBaHT0KG4hUmp3xOFGJmyKcDx5WFXW i2pxDPAy5/wju61+jUOP =aT/o -----END PGP SIGNATURE----- --IS0zKkzwUGydFO0o--