From: Richard Cochran <richardcochran@gmail.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Mugunthan V N <mugunthanvnm@ti.com>,
Sekhar Nori <nsekhar@ti.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org,
Murali Karicheri <m-karicheri2@ti.com>,
Wingman Kwok <w-kwok2@ti.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v4 09/13] net: ethernet: ti: cpts: rework initialization/deinitialization
Date: Tue, 6 Dec 2016 19:04:21 +0100 [thread overview]
Message-ID: <20161206180421.GA20480@localhost.localdomain> (raw)
In-Reply-To: <c0d6d670-cf44-c113-3443-3b5209e68ee2@ti.com>
On Tue, Dec 06, 2016 at 11:49:14AM -0600, Grygorii Strashko wrote:
> But we do reset whole cpsw :( and that's required to support PM use cases as
> suspend/resume.
The code is resetting the clock unconditionally on ifup/down. That
sucks. If you reset the clock *only* after resume, that would be ok.
> There are also PM requirement to shutdown cpsw in case all interfaces are down.
Well, those requirements are not too smart. As an end user, I expect
that ifdown/up does not change the time. There isn't any reason to
reset the clock in this case.
> More over, there are requirement to minimize cpsw power consumption in case all links are
> disconnected (and cpts is special case here).
>
> So, at least resetting of the timecounter still required.
Only if you follow that poorly conceived PM plan. Anyhow, I agree
that it isn't the task of your present series to fix that.
> Ok. I'll try to optimize it following your directions.
What I would like to see is: initialize the cyclecounter fields
exactly once.
Thanks,
Richard
next prev parent reply other threads:[~2016-12-06 18:04 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 20:05 [PATCH v4 00/13] net: ethernet: ti: cpts: update and fixes Grygorii Strashko
2016-12-05 20:05 ` Grygorii Strashko
2016-12-05 20:05 ` [PATCH v4 01/13] net: ethernet: ti: cpts: switch to readl/writel_relaxed() Grygorii Strashko
2016-12-05 20:05 ` Grygorii Strashko
2016-12-05 20:05 ` [PATCH v4 03/13] net: ethernet: ti: cpsw: minimize direct access to struct cpts Grygorii Strashko
2016-12-05 20:05 ` Grygorii Strashko
2016-12-05 20:05 ` [PATCH v4 05/13] net: ethernet: ti: cpts: fix registration order Grygorii Strashko
2016-12-05 20:05 ` Grygorii Strashko
2016-12-05 20:05 ` [PATCH v4 06/13] net: ethernet: ti: cpts: disable cpts when unregistered Grygorii Strashko
2016-12-05 20:05 ` Grygorii Strashko
2016-12-05 20:05 ` [PATCH v4 08/13] net: ethernet: ti: cpts: drop excessive writes to CTRL and INT_EN regs Grygorii Strashko
2016-12-05 20:05 ` Grygorii Strashko
[not found] ` <20161205200525.16664-1-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2016-12-05 20:05 ` [PATCH v4 02/13] net: ethernet: ti: allow cpts to be built separately Grygorii Strashko
2016-12-05 20:05 ` Grygorii Strashko
2016-12-05 20:05 ` Grygorii Strashko
2016-12-05 20:05 ` [PATCH v4 04/13] net: ethernet: ti: cpts: fix unbalanced clk api usage in cpts_register/unregister Grygorii Strashko
2016-12-05 20:05 ` Grygorii Strashko
2016-12-05 20:05 ` Grygorii Strashko
2016-12-05 20:05 ` [PATCH v4 07/13] net: ethernet: ti: cpts: clean up event list if event pool is empty Grygorii Strashko
2016-12-05 20:05 ` Grygorii Strashko
2016-12-05 20:05 ` Grygorii Strashko
2016-12-05 20:05 ` [PATCH v4 09/13] net: ethernet: ti: cpts: rework initialization/deinitialization Grygorii Strashko
2016-12-05 20:05 ` Grygorii Strashko
2016-12-05 20:05 ` Grygorii Strashko
[not found] ` <20161205200525.16664-10-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2016-12-06 13:40 ` Richard Cochran
2016-12-06 13:40 ` Richard Cochran
[not found] ` <20161206134037.GA15946-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2016-12-06 16:45 ` Grygorii Strashko
2016-12-06 16:45 ` Grygorii Strashko
2016-12-06 16:45 ` Grygorii Strashko
[not found] ` <4e7888b6-9f1c-ca31-e83e-15109bf1df3f-l0cyMroinI0@public.gmane.org>
2016-12-06 17:18 ` Richard Cochran
2016-12-06 17:18 ` Richard Cochran
[not found] ` <20161206171802.GA19646-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2016-12-06 17:49 ` Grygorii Strashko
2016-12-06 17:49 ` Grygorii Strashko
2016-12-06 17:49 ` Grygorii Strashko
2016-12-06 18:04 ` Richard Cochran [this message]
2016-12-05 20:05 ` [PATCH v4 10/13] net: ethernet: ti: cpts: move dt props parsing to cpts driver Grygorii Strashko
2016-12-05 20:05 ` Grygorii Strashko
2016-12-05 20:05 ` [PATCH v4 11/13] clocksource: export the clocks_calc_mult_shift to use by timestamp code Grygorii Strashko
2016-12-05 20:05 ` Grygorii Strashko
2016-12-05 20:05 ` [PATCH v4 12/13] net: ethernet: ti: cpts: calc mult and shift from refclk freq Grygorii Strashko
2016-12-05 20:05 ` Grygorii Strashko
2016-12-05 20:05 ` [PATCH v4 13/13] net: ethernet: ti: cpts: fix overflow check period Grygorii Strashko
2016-12-05 20:05 ` Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206180421.GA20480@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=tglx@linutronix.de \
--cc=w-kwok2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.