From: Eduardo Habkost <ehabkost@redhat.com>
To: Greg Kurz <groug@kaod.org>
Cc: qemu-devel@nongnu.org, Halil Pasic <pasic@linux.vnet.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-stable@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers
Date: Tue, 6 Dec 2016 16:46:19 -0200 [thread overview]
Message-ID: <20161206184619.GC4027@thinpad.lan.raisama.net> (raw)
In-Reply-To: <148104617887.7699.984921868108236415.stgit@bahia.lab.toulouse-stg.fr.ibm.com>
On Tue, Dec 06, 2016 at 06:50:47PM +0100, Greg Kurz wrote:
> Since commit "9a4c0e220d8a hw/virtio-pci: fix virtio behaviour", passing
> -device virtio-blk-pci.disable-modern=off has no effect on 2.6 machine
> types because the internal virtio-pci.disable-modern=on compat property
> always prevail.
>
> This should ideally be fixed in the qdev properties core code, but it is
> too late in the QEMU 2.8 schedule. So this patch fixes the issue by setting
> the compat properties for every virtio-*-pci subtypes instead of the base
> virtio-pci type.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
>
> This fix is for both QEMU 2.8 and 2.7.1.
>
> Generated with:
>
> for i in $(git grep 'define TYPE_VIRTIO_.*_PCI' hw/virtio/virtio-pci.h | \
> awk '{print $3 }'); do
> printf '{\\'"\n .driver = %s,"'\\'"\n .property = \"disable-modern\","'\\'"\n .value = \"on\","'\\'"\n },{"'\\'"\n .driver = %s,"'\\'"\n .property = \"disable-legacy\","'\\'"\n .value = \"off\","'\\'"\n }," $i $i
> done
I have manually generated a list of typenames using
"qom-list-types implements=virtio-pci" on all QEMU binaries built
on my system. The list I got is:
* vhost-scsi-pci
* vhost-vsock-pci
* virtio-9p-pci
* virtio-balloon-pci
* virtio-blk-pci
* virtio-crypto-pci
* virtio-gpu-pci
* virtio-input-host-pci
* virtio-keyboard-pci
* virtio-mouse-pci
* virtio-net-pci
* virtio-rng-pci
* virtio-scsi-pci
* virtio-serial-pci
* virtio-tablet-pci
* virtio-vga
The following types are missing in the patch:
* vhost-scsi-pci
* vhost-vsock-pci
* virtio-vga
The following types are abstract classes and shouldn't be on the
compat_props list:
* virtio-input-hid-pci
* virtio-input-pci
>
> include/hw/compat.h | 116 ++++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 114 insertions(+), 2 deletions(-)
>
> diff --git a/include/hw/compat.h b/include/hw/compat.h
> index 0f06e113bee2..793ba3ddb393 100644
> --- a/include/hw/compat.h
> +++ b/include/hw/compat.h
> @@ -26,11 +26,123 @@
> .property = "format_transport_address",\
> .value = "off",\
> },{\
> - .driver = "virtio-pci",\
> + .driver = "virtio-scsi-pci",\
> .property = "disable-modern",\
> .value = "on",\
> },{\
> - .driver = "virtio-pci",\
> + .driver = "virtio-scsi-pci",\
> + .property = "disable-legacy",\
> + .value = "off",\
> + },{\
> + .driver = "virtio-blk-pci",\
> + .property = "disable-modern",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-blk-pci",\
> + .property = "disable-legacy",\
> + .value = "off",\
> + },{\
> + .driver = "virtio-balloon-pci",\
> + .property = "disable-modern",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-balloon-pci",\
> + .property = "disable-legacy",\
> + .value = "off",\
> + },{\
> + .driver = "virtio-serial-pci",\
> + .property = "disable-modern",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-serial-pci",\
> + .property = "disable-legacy",\
> + .value = "off",\
> + },{\
> + .driver = "virtio-net-pci",\
> + .property = "disable-modern",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-net-pci",\
> + .property = "disable-legacy",\
> + .value = "off",\
> + },{\
> + .driver = "virtio-9p-pci",\
> + .property = "disable-modern",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-9p-pci",\
> + .property = "disable-legacy",\
> + .value = "off",\
> + },{\
> + .driver = "virtio-rng-pci",\
> + .property = "disable-modern",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-rng-pci",\
> + .property = "disable-legacy",\
> + .value = "off",\
> + },{\
> + .driver = "virtio-input-pci",\
> + .property = "disable-modern",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-input-pci",\
> + .property = "disable-legacy",\
> + .value = "off",\
> + },{\
> + .driver = "virtio-input-hid-pci",\
> + .property = "disable-modern",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-input-hid-pci",\
> + .property = "disable-legacy",\
> + .value = "off",\
> + },{\
> + .driver = "virtio-keyboard-pci",\
> + .property = "disable-modern",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-keyboard-pci",\
> + .property = "disable-legacy",\
> + .value = "off",\
> + },{\
> + .driver = "virtio-mouse-pci",\
> + .property = "disable-modern",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-mouse-pci",\
> + .property = "disable-legacy",\
> + .value = "off",\
> + },{\
> + .driver = "virtio-tablet-pci",\
> + .property = "disable-modern",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-tablet-pci",\
> + .property = "disable-legacy",\
> + .value = "off",\
> + },{\
> + .driver = "virtio-input-host-pci",\
> + .property = "disable-modern",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-input-host-pci",\
> + .property = "disable-legacy",\
> + .value = "off",\
> + },{\
> + .driver = "virtio-gpu-pci",\
> + .property = "disable-modern",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-gpu-pci",\
> + .property = "disable-legacy",\
> + .value = "off",\
> + },{\
> + .driver = "virtio-crypto-pci",\
> + .property = "disable-modern",\
> + .value = "on",\
> + },{\
> + .driver = "virtio-crypto-pci",\
> .property = "disable-legacy",\
> .value = "off",\
> },
>
--
Eduardo
next prev parent reply other threads:[~2016-12-06 18:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 17:50 [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers Greg Kurz
2016-12-06 18:02 ` Cornelia Huck
2016-12-06 18:46 ` Eduardo Habkost [this message]
2016-12-06 19:19 ` Eduardo Habkost
2016-12-06 19:31 ` [Qemu-devel] [RFC for-2.8] machine: Convert abstract typename on compat_props to subclass names Eduardo Habkost
2016-12-07 13:39 ` Greg Kurz
2016-12-07 13:59 ` Eduardo Habkost
2016-12-07 14:58 ` Greg Kurz
2016-12-09 20:06 ` Eduardo Habkost
2016-12-12 11:26 ` Cornelia Huck
2016-12-12 11:39 ` Greg Kurz
2016-12-12 12:25 ` Cornelia Huck
2016-12-12 17:13 ` Halil Pasic
2016-12-12 17:47 ` Eduardo Habkost
2016-12-12 18:00 ` Halil Pasic
2016-12-12 17:36 ` Eduardo Habkost
2016-12-06 19:31 ` [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers Michael S. Tsirkin
2016-12-06 19:33 ` Eduardo Habkost
2016-12-06 19:36 ` Michael S. Tsirkin
2016-12-06 19:40 ` Eduardo Habkost
2016-12-06 19:44 ` Michael S. Tsirkin
2016-12-06 19:48 ` Eduardo Habkost
2016-12-06 20:30 ` Stefan Hajnoczi
2016-12-07 8:36 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206184619.GC4027@thinpad.lan.raisama.net \
--to=ehabkost@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=groug@kaod.org \
--cc=mst@redhat.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.