From: Gustavo Padovan <gustavo@padovan.org>
To: Tvrtko Ursulin <tursulin@ursulin.net>
Cc: Intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [RFC 5/5] drm: Do not log driver prefix in debug messages
Date: Tue, 6 Dec 2016 17:49:46 -0200 [thread overview]
Message-ID: <20161206194946.GI20601@joana> (raw)
In-Reply-To: <1481050681-23416-6-git-send-email-tvrtko.ursulin@linux.intel.com>
Hi Tvrtko,
2016-12-06 Tvrtko Ursulin <tursulin@ursulin.net>:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Driver prefix is a bit redundant in debug messages. If we choose
> not to log it we change debug messages which used to look like this:
>
> [i915:edp_panel_off [i915]] Wait for panel power off time
>
> to this:
>
> [edp_panel_off [i915]] Wait for panel power off time
Why not remove the second mention to the driver's name instead.
[i915:edp_panel_off] looks more logic to me.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-12-06 19:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 18:57 [RFC 0/5] DRM logging tidy Tvrtko Ursulin
2016-12-06 18:57 ` [RFC 1/5] drm/i915: Give our log messages our name Tvrtko Ursulin
2016-12-06 18:57 ` [RFC 2/5] drm: Respect driver set DRM_NAME in drm_printk Tvrtko Ursulin
2016-12-06 18:57 ` [RFC 3/5] drm: Respect driver set DRM_NAME in drm_dev_printk Tvrtko Ursulin
2016-12-06 18:58 ` [RFC 4/5] drm: Use drm_printk for all logging macros Tvrtko Ursulin
2016-12-06 18:58 ` [RFC 5/5] drm: Do not log driver prefix in debug messages Tvrtko Ursulin
2016-12-06 19:49 ` Gustavo Padovan [this message]
2016-12-07 6:52 ` [Intel-gfx] " Tvrtko Ursulin
2016-12-06 19:31 ` ✗ Fi.CI.BAT: failure for DRM logging tidy Patchwork
2016-12-07 17:44 ` [RFC 0/5] " Robert Bragg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206194946.GI20601@joana \
--to=gustavo@padovan.org \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.