From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg KH) Date: Wed, 7 Dec 2016 10:06:10 +0100 Subject: [PATCH 04/16] drivers/fsi: Add fsi master definition In-Reply-To: <1481076574-54711-1-git-send-email-christopher.lee.bostic@gmail.com> References: <1481076574-54711-1-git-send-email-christopher.lee.bostic@gmail.com> Message-ID: <20161207090610.GB14742@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Dec 06, 2016 at 08:09:30PM -0600, Chris Bostic wrote: > From: Jeremy Kerr > > Signed-off-by: Jeremy Kerr > Signed-off-by: Chris Bostic > --- > drivers/fsi/fsi-core.c | 20 ++++++++++++++++++++ > drivers/fsi/fsi-master.h | 37 +++++++++++++++++++++++++++++++++++++ > 2 files changed, 57 insertions(+) > create mode 100644 drivers/fsi/fsi-master.h > > diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c > index 3d55bd5..ce9428d 100644 > --- a/drivers/fsi/fsi-core.c > +++ b/drivers/fsi/fsi-core.c > @@ -17,6 +17,26 @@ > #include > #include > > +#include "fsi-master.h" > + > +static atomic_t master_idx = ATOMIC_INIT(-1); You don't really want/need an atomic variable, please use the simple ida interface instead. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 04/16] drivers/fsi: Add fsi master definition Date: Wed, 7 Dec 2016 10:06:10 +0100 Message-ID: <20161207090610.GB14742@kroah.com> References: <1481076574-54711-1-git-send-email-christopher.lee.bostic@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1481076574-54711-1-git-send-email-christopher.lee.bostic-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chris Bostic Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jeremy Kerr , joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, andrew-zrmu5oMJ5Fs@public.gmane.org, alistair-Y4h6yKqj69EXC2x5gXVKYQ@public.gmane.org, benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org, Chris Bostic List-Id: devicetree@vger.kernel.org On Tue, Dec 06, 2016 at 08:09:30PM -0600, Chris Bostic wrote: > From: Jeremy Kerr > > Signed-off-by: Jeremy Kerr > Signed-off-by: Chris Bostic > --- > drivers/fsi/fsi-core.c | 20 ++++++++++++++++++++ > drivers/fsi/fsi-master.h | 37 +++++++++++++++++++++++++++++++++++++ > 2 files changed, 57 insertions(+) > create mode 100644 drivers/fsi/fsi-master.h > > diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c > index 3d55bd5..ce9428d 100644 > --- a/drivers/fsi/fsi-core.c > +++ b/drivers/fsi/fsi-core.c > @@ -17,6 +17,26 @@ > #include > #include > > +#include "fsi-master.h" > + > +static atomic_t master_idx = ATOMIC_INIT(-1); You don't really want/need an atomic variable, please use the simple ida interface instead. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752863AbcLGJGP (ORCPT ); Wed, 7 Dec 2016 04:06:15 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:42192 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752812AbcLGJGN (ORCPT ); Wed, 7 Dec 2016 04:06:13 -0500 Date: Wed, 7 Dec 2016 10:06:10 +0100 From: Greg KH To: Chris Bostic Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, sre@kernel.org, mturquette@baylibre.com, geert+renesas@glider.be, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jeremy Kerr , joel@jms.id.au, linux-kernel@vger.kernel.org, andrew@aj.id.au, alistair@popple.id.au, benh@kernel.crashing.org, Chris Bostic Subject: Re: [PATCH 04/16] drivers/fsi: Add fsi master definition Message-ID: <20161207090610.GB14742@kroah.com> References: <1481076574-54711-1-git-send-email-christopher.lee.bostic@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1481076574-54711-1-git-send-email-christopher.lee.bostic@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 06, 2016 at 08:09:30PM -0600, Chris Bostic wrote: > From: Jeremy Kerr > > Signed-off-by: Jeremy Kerr > Signed-off-by: Chris Bostic > --- > drivers/fsi/fsi-core.c | 20 ++++++++++++++++++++ > drivers/fsi/fsi-master.h | 37 +++++++++++++++++++++++++++++++++++++ > 2 files changed, 57 insertions(+) > create mode 100644 drivers/fsi/fsi-master.h > > diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c > index 3d55bd5..ce9428d 100644 > --- a/drivers/fsi/fsi-core.c > +++ b/drivers/fsi/fsi-core.c > @@ -17,6 +17,26 @@ > #include > #include > > +#include "fsi-master.h" > + > +static atomic_t master_idx = ATOMIC_INIT(-1); You don't really want/need an atomic variable, please use the simple ida interface instead. thanks, greg k-h