From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752475AbcLGJMQ (ORCPT ); Wed, 7 Dec 2016 04:12:16 -0500 Received: from mga01.intel.com ([192.55.52.88]:23161 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752005AbcLGJMO (ORCPT ); Wed, 7 Dec 2016 04:12:14 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="1078600940" Date: Wed, 7 Dec 2016 11:11:47 +0200 From: Heikki Krogerus To: Guenter Roeck Cc: Greg KH , Oliver Neukum , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCHv13 2/3] usb: USB Type-C connector class Message-ID: <20161207091147.GA11966@kuha.fi.intel.com> References: <20161124122144.26259-1-heikki.krogerus@linux.intel.com> <20161124122144.26259-3-heikki.krogerus@linux.intel.com> <20161129162744.GA2255@kroah.com> <20161130091910.GD32668@kuha.fi.intel.com> <20161202180439.GA25991@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161202180439.GA25991@roeck-us.net> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 02, 2016 at 10:04:39AM -0800, Guenter Roeck wrote: > At least for my part I very much concentrated on making sure that > the user space ABI as well as the port driver API are sane and usable. > > The driver interface is not my area of expertise. As such, my testing > and understanding of that part was limited to "it appears to work, > it must be ok". I very much relied on you to get this part right. > > That makes me feel really bad. It isn't fun to have my "Reviewed-by" > on a patch that gets (and apparently deserves) a WTF from a senior > kernel maintainer. This hurts both your and my reputation, and obviously > will make me quite hesitant to add a "Reviewed-by:" to the next version > of the series. I don't usually get very upset about stronger comments, even if they are coming from senior kernel maintainer like Greg, but your concern does make me feel like crap. I'm sorry Guenter. Please just note that nobody else has considered the approach as a problem or noticed it before Greg any more then you, and this code has by now been review by many, including some people who I consider senior kernel developers and maintainers, both internally inside Intel and also publicly on these lists. > No more shortcuts, please. No. Br, -- heikki