From: Gustavo Padovan <gustavo@padovan.org>
To: Brian Starkey <brian.starkey@arm.com>
Cc: liviu.dudau@arm.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/atomic: Don't reject reflect-only rotations
Date: Wed, 7 Dec 2016 11:20:47 -0200 [thread overview]
Message-ID: <20161207132047.GL20601@joana> (raw)
In-Reply-To: <1481113099-4788-1-git-send-email-brian.starkey@arm.com>
Hi Brian,
2016-12-07 Brian Starkey <brian.starkey@arm.com>:
> The check to reject combinations of multiple rotation angles is overly
> restrictive and has the side-effect of also failing any rotation value
> which consists only of reflections.
>
> Fix this by relaxing the check to ignore values which contain no
> rotation flags.
>
> Fixes: 6e0c7c3358d4 ("drm/atomic: Reject attempts to use multiple rotation angles at once")
> Signed-off-by: Brian Starkey <brian.starkey@arm.com>
> ---
> drivers/gpu/drm/drm_atomic.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-12-07 13:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 12:18 [PATCH] drm/atomic: Don't reject reflect-only rotations Brian Starkey
2016-12-07 13:20 ` Gustavo Padovan [this message]
2016-12-07 13:32 ` Chris Wilson
2016-12-07 14:52 ` Daniel Vetter
2016-12-07 15:13 ` Ville Syrjälä
2016-12-07 15:54 ` Daniel Vetter
2016-12-07 16:02 ` Ville Syrjälä
2016-12-07 14:12 ` Ville Syrjälä
2016-12-07 14:48 ` Brian Starkey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207132047.GL20601@joana \
--to=gustavo@padovan.org \
--cc=brian.starkey@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=liviu.dudau@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.