From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 02/18] drm/i915/dsi: Fix chv_exec_gpio disabling the GPIOs it is setting Date: Wed, 7 Dec 2016 19:48:02 +0200 Message-ID: <20161207174802.GS31595@intel.com> References: <20161201202925.12220-1-hdegoede@redhat.com> <20161201202925.12220-3-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20161201202925.12220-3-hdegoede@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Hans de Goede Cc: Jani Nikula , intel-gfx , stable@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBEZWMgMDEsIDIwMTYgYXQgMDk6Mjk6MDlQTSArMDEwMCwgSGFucyBkZSBHb2VkZSB3 cm90ZToKPiBTZXQgdGhlIENIVl9HUElPX0dQSU9FTiBiaXQgd2hlbiB1cGRhdGluZyBHUElPcyBm cm9tIGNodl9leGVjX2dwaW8uCj4gCj4gRml4ZXM6IGEwYTZkNGZmZDJhZCAoImRybS9pOTE1L2Rz aTogYWRkIHN1cHBvcnQgZm9yIGdwaW8gZWxlbWVudHMgb24gQ0hWIikKPiBDYzogc3RhYmxlQHZn ZXIua2VybmVsLm9yZwo+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+ IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IFNp Z25lZC1vZmYtYnk6IEhhbnMgZGUgR29lZGUgPGhkZWdvZWRlQHJlZGhhdC5jb20+Cj4gUmV2aWV3 ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+CgpQ dXNoZWQgdG8gZGlucS4gVGhhbmtzIGZvciB0aGUgcGF0Y2guCgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kc2lfcGFuZWxfdmJ0LmMgfCAzICsrLQo+ICAxIGZpbGUgY2hhbmdl ZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RzaV9wYW5lbF92YnQuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RzaV9wYW5lbF92YnQuYwo+IGluZGV4IDU3OWQyZjUuLjQ3Y2QxYjIgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpX3BhbmVsX3ZidC5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpX3BhbmVsX3ZidC5jCj4gQEAgLTMwMCw3 ICszMDAsOCBAQCBzdGF0aWMgdm9pZCBjaHZfZXhlY19ncGlvKHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiwKPiAgCW11dGV4X2xvY2soJmRldl9wcml2LT5zYl9sb2NrKTsKPiAgCXZs dl9pb3NmX3NiX3dyaXRlKGRldl9wcml2LCBwb3J0LCBjZmcxLCAwKTsKPiAgCXZsdl9pb3NmX3Ni X3dyaXRlKGRldl9wcml2LCBwb3J0LCBjZmcwLAo+IC0JCQkgIENIVl9HUElPX0dQSU9DRkdfR1BP IHwgQ0hWX0dQSU9fR1BJT1RYU1RBVEUodmFsdWUpKTsKPiArCQkJICBDSFZfR1BJT19HUElPRU4g fCBDSFZfR1BJT19HUElPQ0ZHX0dQTyB8Cj4gKwkJCSAgQ0hWX0dQSU9fR1BJT1RYU1RBVEUodmFs dWUpKTsKPiAgCW11dGV4X3VubG9jaygmZGV2X3ByaXYtPnNiX2xvY2spOwo+ICB9Cj4gIAo+IC0t IAo+IDIuOS4zCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com ([134.134.136.100]:11419 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbcLGRtB (ORCPT ); Wed, 7 Dec 2016 12:49:01 -0500 Date: Wed, 7 Dec 2016 19:48:02 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Hans de Goede Cc: Daniel Vetter , Jani Nikula , intel-gfx , dri-devel@lists.freedesktop.org, stable@vger.kernel.org, Jani Nikula Subject: Re: [PATCH 02/18] drm/i915/dsi: Fix chv_exec_gpio disabling the GPIOs it is setting Message-ID: <20161207174802.GS31595@intel.com> References: <20161201202925.12220-1-hdegoede@redhat.com> <20161201202925.12220-3-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161201202925.12220-3-hdegoede@redhat.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Dec 01, 2016 at 09:29:09PM +0100, Hans de Goede wrote: > Set the CHV_GPIO_GPIOEN bit when updating GPIOs from chv_exec_gpio. > > Fixes: a0a6d4ffd2ad ("drm/i915/dsi: add support for gpio elements on CHV") > Cc: stable@vger.kernel.org > Cc: Jani Nikula > Cc: Ville Syrj�l� > Signed-off-by: Hans de Goede > Reviewed-by: Ville Syrj�l� Pushed to dinq. Thanks for the patch. > --- > drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c > index 579d2f5..47cd1b2 100644 > --- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c > +++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c > @@ -300,7 +300,8 @@ static void chv_exec_gpio(struct drm_i915_private *dev_priv, > mutex_lock(&dev_priv->sb_lock); > vlv_iosf_sb_write(dev_priv, port, cfg1, 0); > vlv_iosf_sb_write(dev_priv, port, cfg0, > - CHV_GPIO_GPIOCFG_GPO | CHV_GPIO_GPIOTXSTATE(value)); > + CHV_GPIO_GPIOEN | CHV_GPIO_GPIOCFG_GPO | > + CHV_GPIO_GPIOTXSTATE(value)); > mutex_unlock(&dev_priv->sb_lock); > } > > -- > 2.9.3 -- Ville Syrj�l� Intel OTC