From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Oliver Neukum <oneukum@suse.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCHv13,1/3] lib/string: add sysfs_match_string helper
Date: Thu, 8 Dec 2016 09:29:16 +0200 [thread overview]
Message-ID: <20161208072916.GC11966@kuha.fi.intel.com> (raw)
In-Reply-To: <20161207235445.GA15717@roeck-us.net>
On Wed, Dec 07, 2016 at 03:54:45PM -0800, Guenter Roeck wrote:
> > +int __sysfs_match_string(const char * const *array, size_t n, const char *str)
> > +{
> > + const char *item;
> > + int index;
> > +
> > + for (index = 0; index < n; index++) {
> > + item = array[index];
> > + if (!item)
> > + break;
> > + if (!sysfs_streq(item, str))
>
> No idea how this slipped in: sysfs_streq() returns true on a match,
> meaning the "!" here is wrong.
Good catch. Thanks Guenter.
--
heikki
next prev parent reply other threads:[~2016-12-08 7:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 12:21 [PATCHv13 0/3] USB Type-C Connector class Heikki Krogerus
2016-11-24 12:21 ` [PATCHv13 1/3] lib/string: add sysfs_match_string helper Heikki Krogerus
2016-12-07 23:54 ` [PATCHv13,1/3] " Guenter Roeck
2016-12-08 7:29 ` Heikki Krogerus [this message]
2016-11-24 12:21 ` [PATCHv13 2/3] usb: USB Type-C connector class Heikki Krogerus
2016-11-29 16:27 ` Greg KH
2016-11-30 9:19 ` Heikki Krogerus
2016-12-02 18:04 ` Guenter Roeck
2016-12-02 18:22 ` Greg KH
2016-12-07 9:11 ` Heikki Krogerus
2016-12-07 9:46 ` Oliver Neukum
2016-12-07 12:52 ` Heikki Krogerus
2016-12-15 11:50 ` Heikki Krogerus
2016-12-15 12:06 ` Oliver Neukum
2016-12-15 15:01 ` Guenter Roeck
2016-12-19 14:45 ` [RFC PATCH] " Heikki Krogerus
2016-12-19 17:22 ` Guenter Roeck
2016-12-20 14:23 ` Heikki Krogerus
2016-11-24 12:21 ` [PATCHv13 3/3] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208072916.GC11966@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.