All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/xen: Disable strict unused-const-variable checking
Date: Thu, 8 Dec 2016 09:31:48 +0100	[thread overview]
Message-ID: <20161208093148.78bcb271@free-electrons.com> (raw)
In-Reply-To: <CAKmqyKM0RTciLxjAkJ5DnZsq9yON3Er9XdwXMpd9E-CpQqsAYQ@mail.gmail.com>

Hello,

On Wed, 7 Dec 2016 15:39:26 -0800, Alistair Francis wrote:

> >
> > What is this patch fixing? The commit log shouldn't be empty.
> >
> > Is this fixing an autobuilder issue? If so, there should be a reference
> > to it.  
> 
> It is fixing an autobuilder issue, I have added a commit message with
> more details.

Good, but you still forgot (in your v2) a link to the autobuilder issue
being fixed. See
https://git.buildroot.org/buildroot/commit/?id=041c717ec8c251b7bca675086510840f02274967
for an example of how we reference autobuilder issues.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-12-08  8:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-07 19:48 [Buildroot] [PATCH 0/2] Update Xen and fix build issue Alistair Francis
2016-12-07 19:48 ` [Buildroot] [PATCH 1/2] package/xen: Bump Xen to 4.7.1 Alistair Francis
2016-12-07 19:48 ` [Buildroot] [PATCH 2/2] package/xen: Disable strict unused-const-variable checking Alistair Francis
2016-12-07 20:50   ` Thomas Petazzoni
2016-12-07 23:39     ` Alistair Francis
2016-12-08  8:31       ` Thomas Petazzoni [this message]
2016-12-08 20:11         ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161208093148.78bcb271@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.