From: Vinod Koul <vinod.koul@intel.com>
To: Kirtika Ruchandani <kirtika@chromium.org>
Cc: tiwai@suse.com, arnd@arndb.de, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org,
Hardik T Shah <hardik.t.shah@intel.com>,
Omair M Abdullah <omair.m.abdullah@intel.com>,
Jeeja KP <jeeja.kp@intel.com>,
"Subhransu S . Prusty" <subhransu.s.prusty@intel.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] ASoC: Intel: Skylake: remove unused 'out_fmt' variable
Date: Thu, 8 Dec 2016 15:48:27 +0530 [thread overview]
Message-ID: <20161208101826.GZ6408@localhost> (raw)
In-Reply-To: <20161208095959.GY6408@localhost>
On Thu, Dec 08, 2016 at 03:30:01PM +0530, Vinod Koul wrote:
> On Wed, Dec 07, 2016 at 10:01:42PM -0800, Kirtika Ruchandani wrote:
> > Commit 4cd9899f0d16 introduced struct skl_module_fmt* out_fmt without
> > using it. Compiling with W=1 gives the below warning, fix it.
> >
> > sound/soc/intel/skylake/skl-topology.c: In function ‘skl_tplg_update_buffer_size’:
> > sound/soc/intel/skylake/skl-topology.c:301:34: warning: variable ‘out_fmt’ set but not used [-Wunused-but-set-variable]
> >
> > This is a harmless warning and is only being fixed to reduce the noise
> > with W=1 in the kernel.
>
> Heya,
>
> Can you please tell me which tree this warning was found on? At least this
> doesn't exist upstream. The out_fmt is very well used.
Sorry I messed up, got confused mcfg->out_fmt variable :(
This looks fine:
Acked-by: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
next prev parent reply other threads:[~2016-12-08 10:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 6:01 [PATCH] ASoC: Intel: Skylake: remove unused 'out_fmt' variable Kirtika Ruchandani
2016-12-08 10:00 ` Vinod Koul
2016-12-08 10:18 ` Vinod Koul [this message]
2016-12-08 16:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208101826.GZ6408@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=hardik.t.shah@intel.com \
--cc=jeeja.kp@intel.com \
--cc=kirtika@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=omair.m.abdullah@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.