From: Vinod Koul <vinod.koul@intel.com>
To: Kirtika Ruchandani <kirtika@chromium.org>
Cc: tiwai@suse.com, arnd@arndb.de, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, Jeeja KP <jeeja.kp@intel.com>,
"Subhransu S . Prusty" <subhransu.s.prusty@intel.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] ASoC: Intel: Skylake: remove unused 'runtime' variable
Date: Thu, 8 Dec 2016 15:49:25 +0530 [thread overview]
Message-ID: <20161208101925.GA6408@localhost> (raw)
In-Reply-To: <1481178380-139648-1-git-send-email-kirtika@chromium.org>
On Wed, Dec 07, 2016 at 10:26:20PM -0800, Kirtika Ruchandani wrote:
> skl_platform_open() defines and sets 'struct snd_pcm_runtime* runtime'
> but does not use it. Compiling with W=1 gives the following warning,
> fix it.
>
> sound/soc/intel/skylake/skl-pcm.c: In function ‘skl_platform_open’:
> sound/soc/intel/skylake/skl-pcm.c:941:26: warning: variable ‘runtime’ set but not used [-Wunused-but-set-variable]
>
> This was introduced with the initial driver commit a40e693c7f5e
> ("ASoC: Intel: Add Skylake HDA platform driver").
> This is a harmless warning and is only being fixed to reduce the noise
> with W=1 in the kernel.
Acked-by: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
prev parent reply other threads:[~2016-12-08 10:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 6:26 [PATCH] ASoC: Intel: Skylake: remove unused 'runtime' variable Kirtika Ruchandani
2016-12-08 10:19 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208101925.GA6408@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=kirtika@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=subhransu.s.prusty@intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.