From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [patch] ia64: pci: Fix a condition in pcibr_dmamap_ate32()
Date: Thu, 08 Dec 2016 10:59:36 +0000 [thread overview]
Message-ID: <20161208105936.GB11382@elgon.mountain> (raw)
Smatch complains that probably this condition isn't correct because it
first does a comparison and then a mask. Judging from the surrounding
code probably the parenthesis are in the wrong place.
The original code is equivalent to:
if (dma_flags = SN_DMA_ADDR_PHYS)
And it's probably going to be true less often than my corrected version.
Fixes: 83821d3f558d ("[PATCH] PCI: altix: msi support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/arch/ia64/sn/pci/pcibr/pcibr_dma.c b/arch/ia64/sn/pci/pcibr/pcibr_dma.c
index 1e863b277ac9..71c9bf308adf 100644
--- a/arch/ia64/sn/pci/pcibr/pcibr_dma.c
+++ b/arch/ia64/sn/pci/pcibr/pcibr_dma.c
@@ -82,7 +82,7 @@
if (IS_PCIX(pcibus_info))
ate_flags &= ~(PCI32_ATE_PREF);
- if (SN_DMA_ADDRTYPE(dma_flags = SN_DMA_ADDR_PHYS))
+ if (SN_DMA_ADDRTYPE(dma_flags) = SN_DMA_ADDR_PHYS)
xio_addr = IS_PIC_SOFT(pcibus_info) ? PHYS_TO_DMA(paddr) :
PHYS_TO_TIODMA(paddr);
else
next reply other threads:[~2016-12-08 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 10:59 Dan Carpenter [this message]
2018-12-17 9:22 ` [patch] ia64: pci: Fix a condition in pcibr_dmamap_ate32() Dan Carpenter
2018-12-17 18:47 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208105936.GB11382@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.