All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Hesse <list@eworm.de>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Christian Hesse <mail@eworm.de>,
	WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH 1/1] make the systemd unit example more general
Date: Thu, 8 Dec 2016 12:33:43 +0100	[thread overview]
Message-ID: <20161208123343.54f162d7@leda> (raw)
In-Reply-To: <CAHmME9qc02xGhyiXp3J3ugFyCKkWbYY0Fj_q9C1euv1gAYa9qg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

"Jason A. Donenfeld" <Jason@zx2c4.com> on Thu, 2016/12/08 12:18:
> I like this, but two questions.
> 
> 1. Why did you get rid of the ExecStop config saving line?

I do not like units altering configuration. If you want to save configuration
on stop create a second unit with correct dependencies an ordering that
writes the configuration.

> 2. You're not planning to actually package this unit file, are you?

Not sure about that. :-p At least I left it in examples directory. ;)

In first place this is a RFC. Nevertheless we should polish things a bit and
provide a usable systemd unit.

I still do not like to have two files that hold the settings... But no idea
how to get rid of that in a clean way. Having shell code in a systemd unit is
even worse...
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2016-12-08 11:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-08  9:12 [PATCH 1/1] make the systemd unit example more general Christian Hesse
2016-12-08 11:18 ` Jason A. Donenfeld
2016-12-08 11:33   ` Christian Hesse [this message]
2016-12-08 12:48     ` Jason A. Donenfeld
2016-12-08 15:15       ` Jason A. Donenfeld
  -- strict thread matches above, loose matches on Subject: below --
2016-12-08 13:09 Anonymous Anonymous

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161208123343.54f162d7@leda \
    --to=list@eworm.de \
    --cc=Jason@zx2c4.com \
    --cc=mail@eworm.de \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.