From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 08/10] vsock/virtio: mark an internal function static Date: Thu, 8 Dec 2016 16:25:55 +0200 Message-ID: <20161208162458-mutt-send-email-mst@kernel.org> References: <1481038106-24899-1-git-send-email-mst@redhat.com> <1481038106-24899-9-git-send-email-mst@redhat.com> <487d3d4a-7a53-cb45-2cfd-5eb68d9b73f0@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <487d3d4a-7a53-cb45-2cfd-5eb68d9b73f0@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Jason Wang Cc: kvm@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Stefan Hajnoczi , "David S. Miller" List-Id: virtualization@lists.linuxfoundation.org T24gV2VkLCBEZWMgMDcsIDIwMTYgYXQgMTI6MjE6MjJQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiAKPiAKPiBPbiAyMDE25bm0MTLmnIgwNuaXpSAyMzo0MSwgTWljaGFlbCBTLiBUc2lya2lu IHdyb3RlOgo+ID4gdmlydGlvX3RyYW5zcG9ydF9hbGxvY19wa3QgaXMgb25seSB1c2VkIGxvY2Fs bHksIG1ha2UgaXQgc3RhdGljLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBNaWNoYWVsIFMuIFRz aXJraW4gPG1zdEByZWRoYXQuY29tPgo+ID4gLS0tCj4gPiAgIG5ldC92bXdfdnNvY2svdmlydGlv X3RyYW5zcG9ydF9jb21tb24uYyB8IDIgKy0KPiA+ICAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9uZXQvdm13X3Zzb2Nr L3ZpcnRpb190cmFuc3BvcnRfY29tbW9uLmMgYi9uZXQvdm13X3Zzb2NrL3ZpcnRpb190cmFuc3Bv cnRfY29tbW9uLmMKPiA+IGluZGV4IGE1M2IzYTEuLjYxMjAzODQgMTAwNjQ0Cj4gPiAtLS0gYS9u ZXQvdm13X3Zzb2NrL3ZpcnRpb190cmFuc3BvcnRfY29tbW9uLmMKPiA+ICsrKyBiL25ldC92bXdf dnNvY2svdmlydGlvX3RyYW5zcG9ydF9jb21tb24uYwo+ID4gQEAgLTMyLDcgKzMyLDcgQEAgc3Rh dGljIGNvbnN0IHN0cnVjdCB2aXJ0aW9fdHJhbnNwb3J0ICp2aXJ0aW9fdHJhbnNwb3J0X2dldF9v cHModm9pZCkKPiA+ICAgCXJldHVybiBjb250YWluZXJfb2YodCwgc3RydWN0IHZpcnRpb190cmFu c3BvcnQsIHRyYW5zcG9ydCk7Cj4gPiAgIH0KPiA+IC1zdHJ1Y3QgdmlydGlvX3Zzb2NrX3BrdCAq Cj4gPiArc3RhdGljIHN0cnVjdCB2aXJ0aW9fdnNvY2tfcGt0ICoKPiA+ICAgdmlydGlvX3RyYW5z cG9ydF9hbGxvY19wa3Qoc3RydWN0IHZpcnRpb192c29ja19wa3RfaW5mbyAqaW5mbywKPiA+ICAg CQkJICAgc2l6ZV90IGxlbiwKPiA+ICAgCQkJICAgdTMyIHNyY19jaWQsCj4gCj4gR2l0IGdyZXAg c2hvd3MgaXQgd2FzIHVzZWQgYnkgdHJhY2luZy4KClRydWUgYnV0IHRyYWNlX3ZpcnRpb190cmFu c3BvcnRfYWxsb2NfcGt0IGlzIGFsc28gbG9jYWwgdG8KdmlydGlvX3RyYW5zcG9ydF9jb21tb24u YwoKLS0gCk1TVApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgt Zm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4v bGlzdGluZm8vdmlydHVhbGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752937AbcLHO0c (ORCPT ); Thu, 8 Dec 2016 09:26:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41878 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752635AbcLHO0a (ORCPT ); Thu, 8 Dec 2016 09:26:30 -0500 Date: Thu, 8 Dec 2016 16:25:55 +0200 From: "Michael S. Tsirkin" To: Jason Wang Cc: linux-kernel@vger.kernel.org, Stefan Hajnoczi , "David S. Miller" , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [PATCH 08/10] vsock/virtio: mark an internal function static Message-ID: <20161208162458-mutt-send-email-mst@kernel.org> References: <1481038106-24899-1-git-send-email-mst@redhat.com> <1481038106-24899-9-git-send-email-mst@redhat.com> <487d3d4a-7a53-cb45-2cfd-5eb68d9b73f0@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <487d3d4a-7a53-cb45-2cfd-5eb68d9b73f0@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 08 Dec 2016 14:26:00 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 07, 2016 at 12:21:22PM +0800, Jason Wang wrote: > > > On 2016年12月06日 23:41, Michael S. Tsirkin wrote: > > virtio_transport_alloc_pkt is only used locally, make it static. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > net/vmw_vsock/virtio_transport_common.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c > > index a53b3a1..6120384 100644 > > --- a/net/vmw_vsock/virtio_transport_common.c > > +++ b/net/vmw_vsock/virtio_transport_common.c > > @@ -32,7 +32,7 @@ static const struct virtio_transport *virtio_transport_get_ops(void) > > return container_of(t, struct virtio_transport, transport); > > } > > -struct virtio_vsock_pkt * > > +static struct virtio_vsock_pkt * > > virtio_transport_alloc_pkt(struct virtio_vsock_pkt_info *info, > > size_t len, > > u32 src_cid, > > Git grep shows it was used by tracing. True but trace_virtio_transport_alloc_pkt is also local to virtio_transport_common.c -- MST