From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH 1/2] ARM: dts: exynos: Correct clocks for Exynos4 I2S module
Date: Thu, 8 Dec 2016 18:42:17 +0200 [thread overview]
Message-ID: <20161208164217.GB5238@kozik-lap> (raw)
In-Reply-To: <1481194914-20490-1-git-send-email-m.szyprowski@samsung.com>
On Thu, Dec 08, 2016 at 12:01:53PM +0100, Marek Szyprowski wrote:
> "iis", "i2s_opclk0" and "i2s_opclk1" are standard clocks for Exynos4 I2S
> hardware module, so they should be defined in .dtsi file not in the random
> board .dts file.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> arch/arm/boot/dts/exynos4.dtsi | 6 ++++--
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 4 ----
Please update also exynos4412-itop-elite.dts
Beside that looks good.
Krzysztof
> 2 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index c64737b..23d85601 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -64,8 +64,10 @@
> i2s0: i2s@03830000 {
> compatible = "samsung,s5pv210-i2s";
> reg = <0x03830000 0x100>;
> - clocks = <&clock_audss EXYNOS_I2S_BUS>;
> - clock-names = "iis";
> + clocks = <&clock_audss EXYNOS_I2S_BUS>,
> + <&clock_audss EXYNOS_DOUT_AUD_BUS>,
> + <&clock_audss EXYNOS_SCLK_I2S>;
> + clock-names = "iis", "i2s_opclk0", "i2s_opclk1";
> #clock-cells = <1>;
> clock-output-names = "i2s_cdclk0";
> dmas = <&pdma0 12>, <&pdma0 11>, <&pdma0 10>;
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index 8aa19ba..7815efd 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -503,10 +503,6 @@
> pinctrl-0 = <&i2s0_bus>;
> pinctrl-names = "default";
> status = "okay";
> - clocks = <&clock_audss EXYNOS_I2S_BUS>,
> - <&clock_audss EXYNOS_DOUT_AUD_BUS>,
> - <&clock_audss EXYNOS_SCLK_I2S>;
> - clock-names = "iis", "i2s_opclk0", "i2s_opclk1";
> };
>
> &mixer {
> --
> 1.9.1
>
prev parent reply other threads:[~2016-12-08 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 11:01 [PATCH 1/2] ARM: dts: exynos: Correct clocks for Exynos4 I2S module Marek Szyprowski
2016-12-08 11:01 ` [PATCH 2/2] ARM: dts: exynos: Fix initial clocks configuration on Odroid X/X2/U3 boards Marek Szyprowski
2016-12-08 16:44 ` Krzysztof Kozlowski
2016-12-08 17:07 ` Sylwester Nawrocki
2016-12-08 17:13 ` Krzysztof Kozlowski
2016-12-08 16:42 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208164217.GB5238@kozik-lap \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.