Re: [PATCH v3] [media] tvp5150: don't touch register TVP5150_CONF_SHARED_PIN if not needed

[Mauro Carvalho Chehab <mchehab@infradead.org>]

Em Thu, 8 Dec 2016 17:51:02 -0200
Mauro Carvalho Chehab <mchehab@s-opensource.com> escreveu:

> Em Thu,  8 Dec 2016 17:46:53 -0200
> Mauro Carvalho Chehab <mchehab@s-opensource.com> escreveu:
> 
> > commit 460b6c0831cb ("[media] tvp5150: Add s_stream subdev operation
> > support") added a logic that overrides TVP5150_CONF_SHARED_PIN setting,
> > depending on the type of bus set via the .set_fmt() subdev callback.
> > 
> > This is known to cause trobules on devices that don't use a V4L2
> > subdev devnode, and a fix for it was made by commit 47de9bf8931e
> > ("[media] tvp5150: Fix breakage for serial usage"). Unfortunately,
> > such fix doesn't consider the case of progressive video inputs,
> > causing chroma decoding issues on such videos, as it overrides not
> > only the type of video output, but also other unrelated bits.
> > 
> > So, instead of trying to guess, let's detect if the device configuration
> > is set via Device Tree. If not, just ignore the new logic, restoring
> > the original behavior.
> > 
> > Fixes: 460b6c0831cb ("[media] tvp5150: Add s_stream subdev operation support")
> > Cc: Devin Heitmueller <dheitmueller@kernellabs.com>
> > Cc: Javier Martinez Canillas <javier@osg.samsung.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> > ---
> > 
> > changes since version 2: 
> >   - fixed settings for register 0x0d
> >   - tested on WinTV USB2 with S-Video input
> > 
> > I'll do an extra test with HVR-950 on both S-Video and composite soon enough  
> 
> Tested with HVR-950 (USB ID 2040:6513, Hauppauge model 65201, rev A1C0):
> 	- both S-Video and composite entries are working.

Devin,

Btw, if you're willing to test it against the latest Kernel, I recommend
you to also apply the three em28xx patches I just sent upstream, as they
fix a regression with the conversion to dev_foo() print on em28xx driver,
reported by Antti, with happens when removing the em28xx driver from memory.

Such regression happened only at the 4.9-rc development cycle, so it 
shouldn't affect any earlier versions of em28xx.

I'm placing all 4 patches under this branch:
	https://git.linuxtv.org/mchehab/experimental.git/log/?h=em28xx-fixes

Regards,
Mauro