Re: [PATCH v5 1/4] drm: Add a new connector atomic property for link status

From: Manasi Navare <manasi.d.navare@intel.com>
To: Sean Paul <seanpaul@chromium.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v5 1/4] drm: Add a new connector atomic property for link status
Date: Thu, 8 Dec 2016 11:48:47 -0800	[thread overview]
Message-ID: <20161208194847.GD24932@intel.com> (raw)
In-Reply-To: <CAOw6vb+f56hXzQU0aqpUV2iS5Tj7+iub-dsb3TFsxRXWXzTHVQ@mail.gmail.com>

Thanks Sean.
Done, fixed the typo and submitted the patch.

Regards
Manasi

On Thu, Dec 08, 2016 at 02:36:25PM -0500, Sean Paul wrote:
> <snip>
> 
> > diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
> > index 72fa5b2..34eddb9 100644
> > --- a/drivers/gpu/drm/drm_atomic.c
> > +++ b/drivers/gpu/drm/drm_atomic.c
> > @@ -1087,6 +1087,22 @@ int drm_atomic_connector_set_property(struct drm_connector *connector,
> >                  * now?) atomic writes to DPMS property:
> >                  */
> >                 return -EINVAL;
> > +       } else if (property == config->link_status_property) {
> > +               /* Never downgrade from GOOD to BAD on userspace's request here,
> > +                * only hw issues can do that.
> > +                *
> > +                * For an atomic property the userspace doesn't need to be able
> > +                * to understand all the properties, but needs to be able to
> > +                * restore the state itw ants on VT switch. So if the userspace
> 
> s/itw ants/it wants/
> 
> <snip>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx