From: Jean Delvare <jdelvare@suse.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Hardware Monitoring <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH v2] hwmon: (adm1026) Fix overflows seen when writing into limit attributes
Date: Fri, 9 Dec 2016 10:19:08 +0100 [thread overview]
Message-ID: <20161209101908.694c6fef@endymion> (raw)
In-Reply-To: <1481225369-13461-1-git-send-email-linux@roeck-us.net>
On Thu, 8 Dec 2016 11:29:29 -0800, Guenter Roeck wrote:
> Fix overflows seen when writing large values into voltage limit,
> temperature limit, temperature offset, and DAC attributes.
>
> Overflows are seen due to unbound multiplications and additions.
>
> While at it, change the low temperature limit to -128 degrees C,
> since this is the minimum temperature accepted by the chip.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> v2: Provide reason for changing lower temperature range.
>
> drivers/hwmon/adm1026.c | 26 +++++++++++++++++---------
> 1 file changed, 17 insertions(+), 9 deletions(-)
> (...)
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2016-12-09 9:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 19:29 [PATCH v2] hwmon: (adm1026) Fix overflows seen when writing into limit attributes Guenter Roeck
2016-12-09 9:19 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161209101908.694c6fef@endymion \
--to=jdelvare@suse.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.