From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: AndrewCooper <andrew.cooper3@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH RFC v2 3/7] x86emul/test: factor out emul_test_{read_cr, cpuid}
Date: Fri, 9 Dec 2016 13:35:10 +0000 [thread overview]
Message-ID: <20161209133510.GD2709@citrix.com> (raw)
In-Reply-To: <584ABC0402000078001274CC@prv-mh.provo.novell.com>
On Fri, Dec 09, 2016 at 06:13:24AM -0700, Jan Beulich wrote:
[...]
> > --- a/tools/tests/x86_emulator/x86_emulate.h
> > +++ b/tools/tests/x86_emulator/x86_emulate.h
> > @@ -37,3 +37,22 @@
> > bool emul_test_make_stack_executable(void);
> >
> > #include "x86_emulate/x86_emulate.h"
> > +
> > +#define cpu_has_xsave ({ \
> > + unsigned int eax = 1, ecx = 0; \
> > + emul_test_cpuid(&eax, &eax, &ecx, &eax, NULL); \
> > + /* Intentionally checking OSXSAVE here. */ \
> > + (ecx & (1U << 27)) != 0; \
> > +})
>
> ... add it here - why? If you mean to put it here, perhaps all of the
> cpu_has_* should be moved?
>
Yes, I think moving all of them would be better.
Wei.
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-12-09 13:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 12:23 [PATCH RFC v2 0/7] Fuzzing targets for oss-fuzz Wei Liu
2016-12-09 12:23 ` [PATCH RFC v2 1/7] tools/fuzz: introduce libelf target Wei Liu
2016-12-09 12:23 ` [PATCH RFC v2 2/7] x86emul/test: factor out emul_test_make_stack_executable Wei Liu
2016-12-09 13:10 ` Jan Beulich
2016-12-09 12:23 ` [PATCH RFC v2 3/7] x86emul/test: factor out emul_test_{read_cr, cpuid} Wei Liu
2016-12-09 13:13 ` Jan Beulich
2016-12-09 13:35 ` Wei Liu [this message]
2016-12-09 12:23 ` [PATCH RFC v2 4/7] x86emul/test: remove unused macros Wei Liu
2016-12-09 13:15 ` Jan Beulich
2016-12-09 13:35 ` Wei Liu
2016-12-09 12:23 ` [PATCH RFC v2 5/7] tools/fuzz: introduce x86 instruction emulator target Wei Liu
2016-12-09 13:22 ` Jan Beulich
2016-12-09 12:23 ` [PATCH RFC v2 6/7] tools: hook up fuzz directory Wei Liu
2016-12-09 12:23 ` [PATCH RFC v2 7/7] tools/fuzz: add README Wei Liu
2016-12-09 13:07 ` [PATCH RFC v2 0/7] Fuzzing targets for oss-fuzz Jan Beulich
2016-12-09 13:09 ` Wei Liu
2016-12-09 13:25 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161209133510.GD2709@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.