diff for duplicates of <20161209163302.GF9923@lunn.ch> diff --git a/a/1.txt b/N1/1.txt index 7e82322..cc137a4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,24 +1,23 @@ On Fri, Dec 09, 2016 at 05:19:07PM +0100, Gregory CLEMENT wrote: > Hi Andrew, -> =20 -> On jeu., d=C3=A9c. 08 2016, Andrew Lunn <andrew@lunn.ch> wrote: ->=20 +> +> On jeu., d?c. 08 2016, Andrew Lunn <andrew@lunn.ch> wrote: +> > >> +struct str_value_to_freq { > >> + unsigned long value; > >> + u8 freq; > >> +} __packed; > >> + -> >> +static unsigned long read_rtc_register_wa(struct armada38x_rtc *rtc, = -u8 rtc_reg) +> >> +static unsigned long read_rtc_register_wa(struct armada38x_rtc *rtc, u8 rtc_reg) > >> +{ > >> + unsigned long value_array[SAMPLE_NR], i, j, value; -> >> + unsigned long max =3D 0, index_max =3D SAMPLE_NR - 1; +> >> + unsigned long max = 0, index_max = SAMPLE_NR - 1; > >> + struct str_value_to_freq value_to_freq[SAMPLE_NR]; > > > > Hi Gregory > > > > This appears to be putting over 900 bytes on the stack. Is there any ->=20 +> > Actually the structure being packed it is 500 bytes. Did you verify this? I never remember where the __packed needs to go. @@ -32,7 +31,7 @@ suggest squashing patch #3 into #1. > > danger of overflowing the stack? Would it be safer to make these > > arrays part of armada38x_rtc? ->=20 +> > We could do this if you fear a stack overflow. It is generally consider not a good idea to put > $BIG structures on @@ -42,15 +41,3 @@ NFS etc. But it seems unlikely to me reading the RTC will happen with an already deep stack. So this is probably O.K. Andrew - ---=20 -You received this message because you are subscribed to "rtc-linux". -Membership options at http://groups.google.com/group/rtc-linux . -Please read http://groups.google.com/group/rtc-linux/web/checklist -before submitting a driver. ----=20 -You received this message because you are subscribed to the Google Groups "= -rtc-linux" group. -To unsubscribe from this group and stop receiving emails from it, send an e= -mail to rtc-linux+unsubscribe@googlegroups.com. -For more options, visit https://groups.google.com/d/optout. diff --git a/a/content_digest b/N1/content_digest index 1ad9f8e..1a66cf0 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,41 +2,32 @@ "ref\020161208171010.29446-2-gregory.clement@free-electrons.com\0" "ref\020161208172923.GQ26852@lunn.ch\0" "ref\08760mtf538.fsf@free-electrons.com\0" - "From\0Andrew Lunn <andrew@lunn.ch>\0" - "Subject\0[rtc-linux] Re: [PATCH 1/3] rtc: armada38x: improve RTC errata implementation\0" + "From\0andrew@lunn.ch (Andrew Lunn)\0" + "Subject\0[PATCH 1/3] rtc: armada38x: improve RTC errata implementation\0" "Date\0Fri, 9 Dec 2016 17:33:02 +0100\0" - "To\0Gregory CLEMENT <gregory.clement@free-electrons.com>\0" - "Cc\0Alessandro Zummo <a.zummo@towertech.it>" - Alexandre Belloni <alexandre.belloni@free-electrons.com> - rtc-linux@googlegroups.com - Jason Cooper <jason@lakedaemon.net> - Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> - Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - linux-arm-kernel@lists.infradead.org - " Shaker Daibes <shaker@marvell.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Fri, Dec 09, 2016 at 05:19:07PM +0100, Gregory CLEMENT wrote:\n" "> Hi Andrew,\n" - "> =20\n" - "> On jeu., d=C3=A9c. 08 2016, Andrew Lunn <andrew@lunn.ch> wrote:\n" - ">=20\n" + "> \n" + "> On jeu., d?c. 08 2016, Andrew Lunn <andrew@lunn.ch> wrote:\n" + "> \n" "> >> +struct str_value_to_freq {\n" "> >> +\tunsigned long value;\n" "> >> +\tu8 freq;\n" "> >> +} __packed;\n" "> >> +\n" - "> >> +static unsigned long read_rtc_register_wa(struct armada38x_rtc *rtc, =\n" - "u8 rtc_reg)\n" + "> >> +static unsigned long read_rtc_register_wa(struct armada38x_rtc *rtc, u8 rtc_reg)\n" "> >> +{\n" "> >> +\tunsigned long value_array[SAMPLE_NR], i, j, value;\n" - "> >> +\tunsigned long max =3D 0, index_max =3D SAMPLE_NR - 1;\n" + "> >> +\tunsigned long max = 0, index_max = SAMPLE_NR - 1;\n" "> >> +\tstruct str_value_to_freq value_to_freq[SAMPLE_NR];\n" "> >\n" "> > Hi Gregory\n" "> >\n" "> > This appears to be putting over 900 bytes on the stack. Is there any\n" - ">=20\n" + "> \n" "> Actually the structure being packed it is 500 bytes.\n" "\n" "Did you verify this? I never remember where the __packed needs to go.\n" @@ -50,7 +41,7 @@ "\n" "> > danger of overflowing the stack? Would it be safer to make these\n" "> > arrays part of armada38x_rtc?\n" - ">=20\n" + "> \n" "> We could do this if you fear a stack overflow.\n" "\n" "It is generally consider not a good idea to put > $BIG structures on\n" @@ -59,18 +50,6 @@ "NFS etc. But it seems unlikely to me reading the RTC will happen with\n" "an already deep stack. So this is probably O.K.\n" "\n" - " Andrew\n" - "\n" - "--=20\n" - "You received this message because you are subscribed to \"rtc-linux\".\n" - "Membership options at http://groups.google.com/group/rtc-linux .\n" - "Please read http://groups.google.com/group/rtc-linux/web/checklist\n" - "before submitting a driver.\n" - "---=20\n" - "You received this message because you are subscribed to the Google Groups \"=\n" - "rtc-linux\" group.\n" - "To unsubscribe from this group and stop receiving emails from it, send an e=\n" - "mail to rtc-linux+unsubscribe@googlegroups.com.\n" - For more options, visit https://groups.google.com/d/optout. + Andrew -277eaca3a8f94e12664b6c88378399f1da7e8b93ad3b7e4a82897ca95791f84d +daca9af63c64dbdc636f69e1f276730385e5e9e862bc6731aba5a1b5fa65d9ab
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.