All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Cc: "Patrick Scheuring" <patrick.scheuring.dev@gmail.com>,
	"Aurélien Francillon" <aurelien@francillon.net>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: i8042-x86ia64io.h - Comment else/endif of CONFIG_PNP
Date: Fri, 9 Dec 2016 18:00:33 -0800	[thread overview]
Message-ID: <20161210020033.GA15829@dtor-ws> (raw)
In-Reply-To: <20161209235518.14465-1-marcos.souza.org@gmail.com>

On Fri, Dec 09, 2016 at 09:55:09PM -0200, Marcos Paulo de Souza wrote:
> As this define check if huge, this makes easier to read the code.
> 
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>

Applied, thank you.

> ---
>  While reviewing patches from Dmitry about presence of 8042, it makes it
>  much easier to understand the ifdefs...
> 
>  drivers/input/serio/i8042-x86ia64io.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
> index 073246c..ddd3132 100644
> --- a/drivers/input/serio/i8042-x86ia64io.h
> +++ b/drivers/input/serio/i8042-x86ia64io.h
> @@ -1131,10 +1131,10 @@ static int __init i8042_pnp_init(void)
>  	return 0;
>  }
>  
> -#else
> +#else  /* !CONFIG_PNP */
>  static inline int i8042_pnp_init(void) { return 0; }
>  static inline void i8042_pnp_exit(void) { }
> -#endif
> +#endif /* CONFIG_PNP */
>  
>  static int __init i8042_platform_init(void)
>  {
> -- 
> 2.9.3
> 

-- 
Dmitry

      reply	other threads:[~2016-12-10  2:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-09 23:55 [PATCH] Input: i8042-x86ia64io.h - Comment else/endif of CONFIG_PNP Marcos Paulo de Souza
2016-12-09 23:55 ` Marcos Paulo de Souza
2016-12-10  2:00 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161210020033.GA15829@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=aurelien@francillon.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcos.souza.org@gmail.com \
    --cc=patrick.scheuring.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.