From: Eryu Guan <eguan@redhat.com>
To: Ross Zwisler <zwisler@gmail.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
fstests@vger.kernel.org
Subject: Re: [PATCH] generic: Check linking O_TMPFILE into namespace with POSIX ACLs
Date: Sat, 10 Dec 2016 13:39:35 +0800 [thread overview]
Message-ID: <20161210053935.GP29149@eguan.usersys.redhat.com> (raw)
In-Reply-To: <CAOxpaSUMJ13=o0oudfBUZXzXe6sxKRvhnBbAtmd75q_S2R57mQ@mail.gmail.com>
On Fri, Dec 09, 2016 at 01:35:36PM -0700, Ross Zwisler wrote:
> On Wed, Oct 19, 2016 at 5:50 AM, Andreas Gruenbacher
> <agruenba@redhat.com> wrote:
> >
> > When an O_TMPFILE file is linked into a directory with a POSIX default
> > ACL, the file should inherit the default ACL and the umask needs to be
> > ignored.
> >
> > This goes together with generic/004, which tests O_TMPFILE files without
> > POSIX ACLs.
> >
> > Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
>
> I can't seem to get this test to pass. It fails for me with PMEM and
> BRD devices, and with XFS, ext4 and ext2.
Probably you need the latest xfsprogs, specifically this patch
commit 41c702ce4b2bbea59e49384a90e17c64e46bd3ae
Author: Andreas Gruenbacher <agruenba@redhat.com>
Date: Tue Nov 1 10:38:40 2016 +1100
xfs_io: Fix initial -m option
Like "open -m mode", the initial -m option requires a mode argument.
Document these options correctly as well.
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Thanks,
Eryu
next prev parent reply other threads:[~2016-12-10 5:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 11:50 [PATCH] generic: Check linking O_TMPFILE into namespace with POSIX ACLs Andreas Gruenbacher
2016-12-09 20:35 ` Ross Zwisler
2016-12-10 5:39 ` Eryu Guan [this message]
2016-12-12 17:42 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161210053935.GP29149@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=agruenba@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=ross.zwisler@linux.intel.com \
--cc=zwisler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.