Re: [PATCH nft v3] datatype: Display pre-defined inet_service values in host byte order

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Fri, Dec 09, 2016 at 10:35:13PM -0200, Elise Lennion wrote:
> nft describe displays, to the user, which values are available for a selector,
> then the values should be in host byte order.
> 
> Variable size was replaced by len to better match the common pattern.

Applied, thanks Elise.

BTW, I have moved switch_byteorder() to datatype.c, I remember I
suggested you to place it under gmputil.c but given this doesn't take
any mpz_t parameter, let's keep it where we use it and remember this
is there.

Anyway, another issue that would be good to revisit:

# nft describe tcp dport
payload expression, datatype inet_service (internet network service)
(basetype integer), 16 bits

pre-defined symbolic constants:
        tcpmux                          0x0001
        echo                            0x0007
        discard                         0x0009
        ...

The convention is to represent ports in base 10, not as hex. So if you
can follow up with a patch to solve this I'd appreciate it.

Probably this is a new field we can place in struct symbol_table.

Thanks.