From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: csmanjuvijay@gmail.com
Cc: Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] USB: OHCI: pxa27x:fix code errors
Date: Sat, 10 Dec 2016 15:08:24 +0100 [thread overview]
Message-ID: <20161210140824.GB19434@kroah.com> (raw)
In-Reply-To: <1481332408-452-3-git-send-email-csmanjuvijay@gmail.com>
On Sat, Dec 10, 2016 at 01:13:28AM +0000, csmanjuvijay@gmail.com wrote:
> From: Manjunath Goudar <csmanjuvijay@gmail.com>
>
> This patch will fix the checkpatch.pl following errors:
>
> ERROR: space prohibited after that open parenthesis '('
> ERROR: space prohibited before that close parenthesis ')'
>
> Signed-off-by: Manjunath Goudar <csmanjuvijay@gmail.com>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-usb@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/usb/host/ohci-pxa27x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c
> index c73e1ae..0f33583 100644
> --- a/drivers/usb/host/ohci-pxa27x.c
> +++ b/drivers/usb/host/ohci-pxa27x.c
> @@ -158,9 +158,9 @@ static int pxa27x_ohci_select_pmm(struct pxa27x_ohci *pxa_ohci, int mode)
> uhcrhdb |= (0x7<<17);
> break;
> default:
> - printk( KERN_ERR
> + printk(KERN_ERR
> "Invalid mode %d, set to non-power switch mode.\n",
> - mode );
> + mode);
Fix this properly and use dev_err() in a way that actually builds
properly this time.
thanks,
greg k-h
next parent reply other threads:[~2016-12-10 14:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1481332408-452-1-git-send-email-csmanjuvijay@gmail.com>
[not found] ` <1481332408-452-3-git-send-email-csmanjuvijay@gmail.com>
2016-12-10 14:08 ` Greg Kroah-Hartman [this message]
[not found] ` <1481411325-22458-1-git-send-email-csmanjuvijay@gmail.com>
[not found] ` <1481411325-22458-3-git-send-email-csmanjuvijay@gmail.com>
2016-12-11 7:11 ` [PATCH v2 2/2] USB: OHCI: pxa27x:fix code warnig and errors Greg Kroah-Hartman
[not found] ` <1481411325-22458-2-git-send-email-csmanjuvijay@gmail.com>
2016-12-11 7:11 ` [PATCH v2 1/2] USB: OHCI: pxa27x:fix code warnings Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161210140824.GB19434@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=csmanjuvijay@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.