All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [Patch v2 3/9] s6: new package
Date: Sat, 10 Dec 2016 21:52:22 +0100	[thread overview]
Message-ID: <20161210215222.6989afd3@free-electrons.com> (raw)
In-Reply-To: <1481397650-14664-4-git-send-email-eric.le.bihan.dev@free.fr>

Hello,

On Sat, 10 Dec 2016 20:20:44 +0100, Eric Le Bihan wrote:
> This new package provides s6, a small suite of programs for UNIX,
> designed to allow process supervision (a.k.a service supervision), in
> the line of daemontools and runit.
> 
> Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>

Same comments as the previous patches: please fix the --prefix=/usr to
--prefix=$(HOST_DIR)/usr for the host variant. And there is the same
issue in the following patches as well.

> +define S6_INSTALL_STAGING_CMDS
> +	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(STAGING_DIR) install
> +endef

You're doing a plain "make install" here.

> +define HOST_S6_INSTALL_CMDS
> +	$(HOST_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(HOST_DIR) \
> +		install-dynlib \
> +		install-include
> +endef

but not here. Why?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-12-10 20:52 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-10 19:20 [Buildroot] [Patch v2 0/9] Introducing service supervision/management with s6 Eric Le Bihan
2016-12-10 19:20 ` [Buildroot] [Patch v2 1/9] skalibs: new package Eric Le Bihan
2016-12-10 20:46   ` Thomas Petazzoni
2016-12-11 18:18     ` Eric Le Bihan
2016-12-13 21:54       ` Thomas Petazzoni
2016-12-17 13:40         ` Eric Le Bihan
2016-12-17 13:47           ` Thomas Petazzoni
2016-12-10 19:20 ` [Buildroot] [Patch v2 2/9] execline: " Eric Le Bihan
2016-12-10 20:49   ` Thomas Petazzoni
2016-12-11 18:30     ` Eric Le Bihan
2016-12-10 19:20 ` [Buildroot] [Patch v2 3/9] s6: " Eric Le Bihan
2016-12-10 20:52   ` Thomas Petazzoni [this message]
2016-12-11 18:38     ` Eric Le Bihan
2016-12-13 21:55       ` Thomas Petazzoni
2016-12-10 19:20 ` [Buildroot] [Patch v2 4/9] s6-dns: " Eric Le Bihan
2016-12-10 19:20 ` [Buildroot] [Patch v2 5/9] s6-networking: " Eric Le Bihan
2016-12-10 19:20 ` [Buildroot] [Patch v2 6/9] s6-rc: " Eric Le Bihan
2016-12-10 19:51   ` Baruch Siach
2016-12-10 20:41     ` Eric Le Bihan
2016-12-11 13:27       ` Thomas Petazzoni
2016-12-10 19:20 ` [Buildroot] [Patch v2 7/9] s6-portable-utils: " Eric Le Bihan
2016-12-10 19:20 ` [Buildroot] [Patch v2 8/9] s6-linux-utils: " Eric Le Bihan
2016-12-10 19:20 ` [Buildroot] [Patch v2 9/9] s6-linux-init: " Eric Le Bihan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161210215222.6989afd3@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.