All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Nick Desaulniers <nick.desaulniers@gmail.com>
Cc: rjw@rjwysocki.net, len.brown@intel.com, tglx@linutronix.de,
	mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: small formatting fixes
Date: Mon, 12 Dec 2016 09:56:20 +0100	[thread overview]
Message-ID: <20161212085620.GA738@amd> (raw)
In-Reply-To: <20161212072541.28435-1-nick.desaulniers@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1533 bytes --]

Hi!

> A quick cleanup that passes scripts/checkpatch.pl -f <file>.
> 
> Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>

> --- a/arch/x86/kernel/acpi/cstate.c
> +++ b/arch/x86/kernel/acpi/cstate.c
> @@ -1,7 +1,7 @@
>  /*
>   * Copyright (C) 2005 Intel Corporation
> - * 	Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
> - * 	- Added _PDC for SMP C-states on Intel CPUs
> + * Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
> + * - Added _PDC for SMP C-states on Intel CPUs
>   */
>  
>  #include <linux/kernel.h>

No.

> @@ -50,8 +49,8 @@ void acpi_processor_power_init_bm_check(struct acpi_processor_flags *flags,
>  	 * P4, Core and beyond CPUs
>  	 */
>  	if (c->x86_vendor == X86_VENDOR_INTEL &&
> -	    (c->x86 > 0xf || (c->x86 == 6 && c->x86_model >= 0x0f)))
> -			flags->bm_control = 0;
> +			(c->x86 > 0xf || (c->x86 == 6 && c->x86_model >= 0x0f)))
> +		flags->bm_control = 0;
>  }
>  EXPORT_SYMBOL(acpi_processor_power_init_bm_check);
>

No.

> @@ -159,13 +158,14 @@ void __cpuidle acpi_processor_ffh_cstate_enter(struct acpi_processor_cx *cx)
>  
>  	percpu_entry = per_cpu_ptr(cpu_cstate_entry, cpu);
>  	mwait_idle_with_hints(percpu_entry->states[cx->index].eax,
> -	                      percpu_entry->states[cx->index].ecx);
> +		percpu_entry->states[cx->index].ecx);
>  }

No.

Rest is good.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2016-12-12  8:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-12  7:25 [PATCH] ACPI: small formatting fixes Nick Desaulniers
2016-12-12  7:25 ` Nick Desaulniers
2016-12-12  8:56 ` Pavel Machek [this message]
2016-12-12 17:56   ` Nick Desaulniers
2016-12-12 18:39     ` Joe Perches
2016-12-12 22:22       ` Pavel Machek
2016-12-12 22:32         ` Joe Perches
2016-12-12 23:08           ` Pavel Machek
2016-12-12 23:13             ` Joe Perches
2016-12-13 10:00           ` Bjørn Mork
2016-12-12 23:20         ` Nick Desaulniers
2016-12-12 23:22           ` Joe Perches
2016-12-13 19:00             ` Pavel Machek
2016-12-23  3:19               ` Nick Desaulniers
2016-12-23 12:10                 ` Rafael J. Wysocki
2017-01-11 20:03                 ` Pavel Machek
  -- strict thread matches above, loose matches on Subject: below --
2016-11-21  6:51 Nick Desaulniers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161212085620.GA738@amd \
    --to=pavel@ucw.cz \
    --cc=hpa@zytor.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nick.desaulniers@gmail.com \
    --cc=rjw@rjwysocki.net \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.