Re: [bug report] IB/mlx5: Support IB_WR_REG_SIG_MR

[Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>]

On Sun, Dec 11, 2016 at 11:23:26AM +0200, Leon Romanovsky wrote:
> >   3624          case IB_SIG_TYPE_T10_DIF:
> >   3625                  psv_seg->transient_sig = cpu_to_be32(domain->sig.dif.bg << 16 |
> >   3626                                                       domain->sig.dif.app_tag);
> >   3627                  psv_seg->ref_tag = cpu_to_be32(domain->sig.dif.ref_tag);
> >   3628                  break;
> >   3629          default:
> >   3630                  pr_err("Bad signature type given.\n");
> >   3631                  return 1;
> >
> > Why do we return 1 here instead of a negative error code?
> 
> Yes, probably better to return something like EINVAL, instead of 1.
> do you want us to handle it?
> 

Yes, please.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html