From: Paul Mackerras <paulus@ozlabs.org>
To: Markus Hitter <mah@jump-ing.de>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 0/3] gitk: memory consumption improvements
Date: Mon, 12 Dec 2016 20:51:19 +1100 [thread overview]
Message-ID: <20161212095119.GF20934@fergus.ozlabs.ibm.com> (raw)
In-Reply-To: <de7cd593-0c10-4e93-1681-7e123504f5d5@jump-ing.de>
On Mon, Nov 07, 2016 at 07:54:28PM +0100, Markus Hitter wrote:
>
> List, Paul,
>
> after searching for a while on why Gitk sometimes consumes exorbitant amounts of memory I found a pair of minor issues and also a big one: the text widget comes with an unlimited undo manager, which is turned on be default. Considering that each line is inserted seperately, this piles up a huuuge undo stack ... for a read-only text widget. Simply turning off this undo manager saves about 95% of memory when viewing large commits (with tens of thousands of diff lines).
>
> 3 patches are about to follow:
>
> - turn off the undo manager,
>
> - forget already closed file descriptors and
>
> - forget the 'commitinfo' array on a reload to enforce reloading it.
>
> I hope this finds you appreciation.
Thanks for the good work in tracking this down and making the patches.
I have applied the series. Apologies for slow response (life has been
extremely busy for me this year).
Paul.
prev parent reply other threads:[~2016-12-12 9:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 18:54 [PATCH 0/3] gitk: memory consumption improvements Markus Hitter
2016-11-07 18:57 ` [PATCH 1/3] gitk: turn off undo manager in the text widget Markus Hitter
2016-11-07 19:01 ` [PATCH 2/3] gitk: remove closed file descriptors from $blobdifffd Markus Hitter
2016-11-07 19:03 ` [PATCH 3/3] gitk: clear array 'commitinfo' on reload Markus Hitter
2016-11-07 22:13 ` [PATCH 1/3] gitk: turn off undo manager in the text widget Jacob Keller
2016-11-08 21:37 ` [PATCH 0/3] gitk: memory consumption improvements Junio C Hamano
2016-11-09 12:39 ` Markus Hitter
2016-11-09 23:04 ` Junio C Hamano
2016-12-12 9:51 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212095119.GF20934@fergus.ozlabs.ibm.com \
--to=paulus@ozlabs.org \
--cc=git@vger.kernel.org \
--cc=mah@jump-ing.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.