From: Stephen Hemminger <stephen@networkplumber.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: tgraf@suug.ch, alexei.starovoitov@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 -net-next] lwt: BPF support for LWT
Date: Mon, 12 Dec 2016 15:41:34 -0800 [thread overview]
Message-ID: <20161212154134.51638dae@xeon-e3> (raw)
In-Reply-To: <43d8d9ddc604f83e9abff9f998b9581210529c30.1481501217.git.daniel@iogearbox.net>
On Mon, 12 Dec 2016 01:14:35 +0100
Daniel Borkmann <daniel@iogearbox.net> wrote:
> +
> +static int lwt_parse_bpf(struct rtattr *rta, size_t len, int *argcp, char ***argvp,
> + int attr, const enum bpf_prog_type bpf_type)
Please break long lines like this.
> +
> + /* argv is currently the first unparsed argument,
> + * but the lwt_parse_encap() caller will move to the next,
> + * so step back */
> + *argcp = argc + 1;
iproute2 uses kernel comment style.
I went ahead and fixed these.
next prev parent reply other threads:[~2016-12-13 17:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 0:14 [PATCH iproute2 -net-next] lwt: BPF support for LWT Daniel Borkmann
2016-12-12 23:41 ` Stephen Hemminger [this message]
2016-12-14 7:31 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212154134.51638dae@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.