All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Tim Deegan <tim@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <JBeulich@suse.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 5/7] tools/fuzz: introduce x86 instruction emulator target
Date: Mon, 12 Dec 2016 18:00:55 +0000	[thread overview]
Message-ID: <20161212180055.GR25175@citrix.com> (raw)
In-Reply-To: <22606.58764.682677.354033@mariner.uk.xensource.com>

On Mon, Dec 12, 2016 at 05:59:40PM +0000, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH v3 5/7] tools/fuzz: introduce x86 instruction emulator target"):
> > On Mon, Dec 12, 2016 at 04:30:30AM -0700, Jan Beulich wrote:
> >>> On 12.12.16 at 12:19, <wei.liu2@citrix.com> wrote:
> > > > I mean "states". There are three states we need to reset.
> > > 
> > > Hmm, to me as a non-native speaker it feels wrong to use plural
> > > here (just like for e.g. milk), but maybe I'm wrong.
> > 
> > "State" is countable when used to represent the condition of
> > somebody/something.  Various other meanings of "state" don't apply here.
> 
> I think "three states" can only be used to mean three alternative
> possible values of the same variable.  It cannot be used to mean three
> separate variables.
> 
> So "a state" is one of the possible values.  You can also say
> something like "the system is in a broken state", but again, this
> refers to a specific state amongst all the possible different states.
> 
> "Reset all states" is really odd and could almost never be right.
> 

David suggested "reset all state variables". That's what I have now.

Wei.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-12-12 18:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-12  9:28 [PATCH v3 0/7] Fuzzing targets for oss-fuzz Wei Liu
2016-12-12  9:28 ` [PATCH v3 1/7] tools/fuzz: introduce libelf target Wei Liu
2016-12-12  9:43   ` Jan Beulich
2016-12-12  9:28 ` [PATCH v3 2/7] x86emul/test: factor out emul_test_make_stack_executable Wei Liu
2016-12-12  9:28 ` [PATCH v3 3/7] x86emul/test: factor out emul_test_{read_cr, cpuid} Wei Liu
2016-12-12  9:45   ` Jan Beulich
2016-12-12  9:51     ` Wei Liu
2016-12-12  9:28 ` [PATCH v3 4/7] x86emul/test: factor out emul_test_get_fpu Wei Liu
2016-12-12  9:46   ` Jan Beulich
2016-12-12  9:28 ` [PATCH v3 5/7] tools/fuzz: introduce x86 instruction emulator target Wei Liu
2016-12-12  9:58   ` Jan Beulich
2016-12-12 11:19     ` Wei Liu
2016-12-12 11:30       ` Jan Beulich
2016-12-12 11:40         ` Wei Liu
2016-12-12 17:59           ` Ian Jackson
2016-12-12 18:00             ` Wei Liu [this message]
2016-12-12 17:51     ` Wei Liu
2016-12-13  7:42       ` Jan Beulich
2016-12-16  9:03   ` George Dunlap
2016-12-12  9:28 ` [PATCH v3 6/7] tools: hook up fuzz directory Wei Liu
2016-12-12  9:28 ` [PATCH v3 7/7] tools/fuzz: add README Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161212180055.GR25175@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.