From: Wolfram Sang <wsa@the-dreams.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Jean Delvare <jdelvare@suse.com>,
m.frohiky@gmail.com,
Christian Gmeiner <christian.gmeiner@gmail.com>
Subject: Re: [PATCH] Input: ar1021-i2c - fix too long name in driver's device table
Date: Tue, 13 Dec 2016 06:58:17 +0100 [thread overview]
Message-ID: <20161213055816.GA2125@katana> (raw)
In-Reply-To: <20161212235702.GA10843@dtor-ws>
[-- Attachment #1: Type: text/plain, Size: 732 bytes --]
On Mon, Dec 12, 2016 at 03:57:02PM -0800, Dmitry Torokhov wrote:
> The name field in structure i2c_device_id is 20 characters, and we
> expect it to be NULL-terminated, however we are trying to stuff it with
> 21 bytes and thus NULL-terminator is lost. This causes issues when one
> creates device with name "MICROCHIP_AR1021_I2C" as i2c core cuts off the
> last "C", and automatic module loading by alias does not work as result.
>
> The -I2C suffix in the device name is superfluous, we know what bus we
> are dealing with, so let's drop it.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=116211
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-12-13 5:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 23:57 [PATCH] Input: ar1021-i2c - fix too long name in driver's device table Dmitry Torokhov
2016-12-13 5:58 ` Wolfram Sang [this message]
2016-12-13 7:41 ` Christian Gmeiner
2016-12-13 14:06 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161213055816.GA2125@katana \
--to=wsa@the-dreams.de \
--cc=christian.gmeiner@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.frohiky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.