From: "Daniel P. Berrange" <berrange@redhat.com>
To: "Longpeng (Mike)" <longpeng2@huawei.com>
Cc: QEMU-DEV <qemu-devel@nongnu.org>,
famz@redhat.com, arei.gonglei@huawei.com, wu.wubin@huawei.com,
jianjay.zhou@huawei.com
Subject: Re: [Qemu-devel] [PATCH for-2.9 v3 0/6] crypto: add HMAC algorithms support
Date: Tue, 13 Dec 2016 09:30:24 +0000 [thread overview]
Message-ID: <20161213093024.GC12730@redhat.com> (raw)
In-Reply-To: <584FA4A4.3050507@huawei.com>
On Tue, Dec 13, 2016 at 03:35:00PM +0800, Longpeng (Mike) wrote:
> Hi Daniel,
>
> The error is due to auto-build environment doesn't support both gcrypt and
> nettle, and it's glibc(2.28) is too old, so I think I should add no-op in
> hmac-glib.c when glibc is older than 2.30. for example:
>
> #include <...>
>
> #if GLIB_CHECK_VERSION(2, 30, 0)
> ....
> #else
> ...(no-op func)
> #endif
>
> Do you have any suggestion ?
Yep, you need to wrap the entire hmac-glib.c file in the #if so that you
hide the method impl too.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
next prev parent reply other threads:[~2016-12-13 9:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 7:01 [Qemu-devel] [PATCH for-2.9 v3 0/6] crypto: add HMAC algorithms support Longpeng(Mike)
2016-12-13 7:01 ` [Qemu-devel] [PATCH for-2.9 v3 1/6] configure: add CONFIG_GCRYPT_HMAC item Longpeng(Mike)
2016-12-13 7:01 ` [Qemu-devel] [PATCH for-2.9 v3 2/6] crypto: add HMAC algorithms framework Longpeng(Mike)
2016-12-13 7:01 ` [Qemu-devel] [PATCH for-2.9 v3 3/6] crypto: support HMAC algorithms based on libgcrypt Longpeng(Mike)
2016-12-13 7:01 ` [Qemu-devel] [PATCH for-2.9 v3 4/6] crypto: support HMAC algorithms based on glibc Longpeng(Mike)
2016-12-13 9:34 ` Daniel P. Berrange
2016-12-13 7:01 ` [Qemu-devel] [PATCH for-2.9 v3 5/6] crypto: support HMAC algorithms based on nettle Longpeng(Mike)
2016-12-13 7:01 ` [Qemu-devel] [PATCH for-2.9 v3 6/6] crypto: add HMAC algorithms testcases Longpeng(Mike)
2016-12-13 7:14 ` [Qemu-devel] [PATCH for-2.9 v3 0/6] crypto: add HMAC algorithms support no-reply
2016-12-13 7:35 ` Longpeng (Mike)
2016-12-13 9:30 ` Daniel P. Berrange [this message]
2016-12-13 9:35 ` Daniel P. Berrange
2016-12-13 9:36 ` Longpeng (Mike)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161213093024.GC12730@redhat.com \
--to=berrange@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=famz@redhat.com \
--cc=jianjay.zhou@huawei.com \
--cc=longpeng2@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=wu.wubin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.