All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, lvivier@redhat.com,
	thuth@redhat.com
Subject: Re: [PATCH kvm-unit-tests v2] Add git-diff orderFile
Date: Tue, 13 Dec 2016 17:06:08 +0100	[thread overview]
Message-ID: <20161213160607.GB9488@potion> (raw)
In-Reply-To: <20161212140853.5061-1-drjones@redhat.com>

2016-12-12 15:08+0100, Andrew Jones:
> It's helpful to have a common order of file types in patches.
> Applying git-diff's orderFile feature allows us to do that. Just
> do 'git config diff.orderFile scripts/git.difforder' to enable it.
> 
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> v2 changed the file name and forces common (lib/) before unit
>    test code. Rearranged some other stuff too; now the approach
>    is docs, running, building, common-lib/arch-lib (can't force
>    common-lib to be first), unit-test, unittests.cfg, and, as
>    much as possible, helpers before users and headers before code.

Acked-by: Radim Krčmář <rkrcmar@redhat.com>

(While burning the pile of review notes I prepared for v2 through v9;
 v9 would ask for a checkpatch script to verify the order. ;])

  reply	other threads:[~2016-12-13 16:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-12 14:08 [PATCH kvm-unit-tests v2] Add git-diff orderFile Andrew Jones
2016-12-13 16:06 ` Radim Krčmář [this message]
2017-01-12 12:16   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161213160607.GB9488@potion \
    --to=rkrcmar@redhat.com \
    --cc=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.