From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: tune down the fast link training vs boot fail Date: Tue, 13 Dec 2016 22:23:05 +0200 Message-ID: <20161213202305.GQ31595@intel.com> References: <20161213195414.28923-1-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id A19116E665 for ; Tue, 13 Dec 2016 20:23:09 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20161213195414.28923-1-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , Linus Torvalds , stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBEZWMgMTMsIDIwMTYgYXQgMDg6NTQ6MTRQTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBJdCdzIGJlZW4gdW5maXhlZCBzaW5jZSBhIHdoaWxlIGFuZCBubyBvbmUgaXMgaW1t ZWRpYXRlbHkgd29ya2luZyBvbgo+IHRoaXMuIEFuZCB3ZSBoYXZlIHRoZSBGSVhNRSBhbHJlYWR5 LiBBbmQgbm93IGFsc28gYSB0YXNrIGluIHRoZSBEUAo+IHRlYW0ncyBiYWNrbG9nLgo+IAo+IENj OiBMaW51cyBUb3J2YWxkcyA8dG9ydmFsZHNAbGludXgtZm91bmRhdGlvbi5vcmc+Cj4gQ2M6IHN0 YWJsZUB2Z2VyLmtlcm5lbC5vcmcKPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxh QGxpbnV4LmludGVsLmNvbT4KPiBSZWZlcmVuY2VzOiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9hcmNoaXZlcy9pbnRlbC1nZngvMjAxNi1KdWx5LzEwMTk1MS5odG1sCj4gU2lnbmVkLW9m Zi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+Cj4gLS0tCj4gSGkg TGludXMsCj4gCj4gRmVlbCBmcmVlIHRvIGFwcGx5IGRpcmVjdGx5IGluIGNhc2UgaXQgYW5ub3lz IHRvbyBtdWNoIGFuZCB5b3UgZG9uJ3QKPiB3YW50IHRvIHdhaXQgZm9yIHlvdXIgcHJlc2VudHMg Oy0pCj4gCj4gQ2hlZXJzLCBEYW5pZWwKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHAuYyB8IDQgKystLQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRl bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IGluZGV4IGRiNzViYjkyNGU0 OC4uNmU4NzVkNDI2NDJhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2RwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gQEAgLTQwMTQs OCArNDAxNCw4IEBAIGludGVsX2RwX2NoZWNrX2xpbmtfc3RhdHVzKHN0cnVjdCBpbnRlbF9kcCAq aW50ZWxfZHApCj4gIAkJcmV0dXJuOwo+ICAKPiAgCS8qIEZJWE1FOiB3ZSBuZWVkIHRvIHN5bmNo cm9uaXplIHRoaXMgc29ydCBvZiBzdHVmZiB3aXRoIGhhcmR3YXJlCj4gLQkgKiByZWFkb3V0ICov Cj4gLQlpZiAoV0FSTl9PTl9PTkNFKCFpbnRlbF9kcC0+bGFuZV9jb3VudCkpCj4gKwkgKiByZWFk b3V0LiBDdXJyZW50bHkgZmFzdCBsaW5rIHRyYWluaW5nIGRvZXNuJ3Qgd29yayBvbiBib290LXVw LiAqLwoKcy9mYXN0IGxpbmsgdHJhaW5pbmcvbGluayByZXRyYWluaW5nLyBpcyB3aGF0IEknZCBw dXQgdGhlcmUuCgpJJ20gYSBiaXQgc2FkIHRvIGhpZGUgaXQgYnV0IGRvZXNuJ3QgbG9vayBsaWtl IHRoZSBwcm9wZXIgc29sdXRpb24gaXMKZ29pbmcgdG8gaGFwcGVuIGFueSB0aW1lIHNvb24uCgpB Y2tlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K Cj4gKwlpZiAoIWludGVsX2RwLT5sYW5lX2NvdW50KQo+ICAJCXJldHVybjsKPiAgCj4gIAkvKiBp ZiBsaW5rIHRyYWluaW5nIGlzIHJlcXVlc3RlZCB3ZSBzaG91bGQgcGVyZm9ybSBpdCBhbHdheXMg Ki8KPiAtLSAKPiAyLjExLjAKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com ([134.134.136.100]:22629 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753566AbcLMUXL (ORCPT ); Tue, 13 Dec 2016 15:23:11 -0500 Date: Tue, 13 Dec 2016 22:23:05 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Daniel Vetter Cc: Intel Graphics Development , Linus Torvalds , stable@vger.kernel.org, Daniel Vetter Subject: Re: [PATCH] drm/i915: tune down the fast link training vs boot fail Message-ID: <20161213202305.GQ31595@intel.com> References: <20161213195414.28923-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161213195414.28923-1-daniel.vetter@ffwll.ch> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Dec 13, 2016 at 08:54:14PM +0100, Daniel Vetter wrote: > It's been unfixed since a while and no one is immediately working on > this. And we have the FIXME already. And now also a task in the DP > team's backlog. > > Cc: Linus Torvalds > Cc: stable@vger.kernel.org > Cc: Ville Syrj�l� > References: https://lists.freedesktop.org/archives/intel-gfx/2016-July/101951.html > Signed-off-by: Daniel Vetter > --- > Hi Linus, > > Feel free to apply directly in case it annoys too much and you don't > want to wait for your presents ;-) > > Cheers, Daniel > --- > drivers/gpu/drm/i915/intel_dp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index db75bb924e48..6e875d42642a 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -4014,8 +4014,8 @@ intel_dp_check_link_status(struct intel_dp *intel_dp) > return; > > /* FIXME: we need to synchronize this sort of stuff with hardware > - * readout */ > - if (WARN_ON_ONCE(!intel_dp->lane_count)) > + * readout. Currently fast link training doesn't work on boot-up. */ s/fast link training/link retraining/ is what I'd put there. I'm a bit sad to hide it but doesn't look like the proper solution is going to happen any time soon. Acked-by: Ville Syrj�l� > + if (!intel_dp->lane_count) > return; > > /* if link training is requested we should perform it always */ > -- > 2.11.0 -- Ville Syrj�l� Intel OTC