From: Baoquan He <bhe@redhat.com>
To: Liu ping fan <kernelfans@gmail.com>
Cc: Dave Young <dyoung@redhat.com>,
kexec@lists.infradead.org, Pingfan Liu <piliu@redhat.com>
Subject: Re: [PATCH 1/2] kexec: add a dummy note for each offline cpu
Date: Wed, 14 Dec 2016 16:44:02 +0800 [thread overview]
Message-ID: <20161214084402.GB9239@x1> (raw)
In-Reply-To: <CAFgQCTvcywxOxGm-LvHeTzksYSWrxzwN7zCa9y-LJbsgnjr9Xg@mail.gmail.com>
On 12/14/16 at 04:39pm, Liu ping fan wrote:
> On Wed, Dec 14, 2016 at 4:25 PM, Baoquan He <bhe@redhat.com> wrote:
> > On 12/14/16 at 04:15pm, Liu ping fan wrote:
> >> On Wed, Dec 14, 2016 at 3:40 PM, Baoquan He <bhe@redhat.com> wrote:
> >> > On 12/14/16 at 02:11pm, Pingfan Liu wrote:
> >> >> kexec-tools always allocates program headers for each possible cpu. This
> >> >> incurs zero PT_NOTE for offline cpu. We mark this case so that later,
> >> >> the capture kernel can distinguish it from the mistake of allocated
> >> >> program header.
> >> >> The counterpart of the capture kernel comes in next patch.
> >> >
> >> > When you execute dmesg on your testing machine and grep nr_cpu_ids,
> >> > what's the value of nr_cpu_ids?
> >> >
> >> nr_cpu_ids=128
> >
> > And what's the cpu number of in "lscpu" command?
>
> NUMA node1 CPU(s): 0-7
>
> The system booted up with 128 possible cpu and only 8 online.
> Also I tested on x86 guest, after bootup with 8 cpus, then offline 4
> of them, the zero PT_NOTE warning buzz too.
Yes, this is what I think not quite appropriate using
for_each_cpu_not(cpu, cpu_online_mask). Maybe it need try to save on
those cpus which is present but not online. not online seems not good,
it's not reasonable to save those getting apic but no cpu plugged.
Thanks
Baoquan
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2016-12-14 8:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 6:11 [PATCH 1/2] kexec: add a dummy note for each offline cpu Pingfan Liu
2016-12-14 6:11 ` [PATCH 2/2] [fs] proc/vmcore: check the dummy place holder for offline cpu to avoid warning Pingfan Liu
2016-12-14 23:56 ` Xunlei Pang
2016-12-15 3:04 ` Liu ping fan
2016-12-14 6:19 ` [PATCH 1/2] kexec: add a dummy note for each offline cpu Liu ping fan
2016-12-14 7:40 ` Baoquan He
2016-12-14 8:15 ` Liu ping fan
2016-12-14 8:25 ` Baoquan He
2016-12-14 8:39 ` Liu ping fan
2016-12-14 8:44 ` Baoquan He [this message]
2016-12-14 9:06 ` Liu ping fan
2016-12-14 8:48 ` Xunlei Pang
2016-12-14 8:56 ` Liu ping fan
2016-12-14 9:10 ` Xunlei Pang
2016-12-14 9:13 ` Liu ping fan
2016-12-14 23:49 ` Xunlei Pang
2016-12-15 7:16 ` Dave Young
2016-12-15 8:43 ` Liu ping fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161214084402.GB9239@x1 \
--to=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=kernelfans@gmail.com \
--cc=kexec@lists.infradead.org \
--cc=piliu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.