From: Greg KH <gregkh@linuxfoundation.org>
To: Joel Stanley <joel@jms.id.au>
Cc: Michael Ellerman <patch-notifications@ellerman.id.au>,
Segher Boessenkool <segher@kernel.crashing.org>,
linuxppc-dev@ozlabs.org, markus@trippelsdorf.de,
amodra@gmail.com
Subject: Re: powerpc: cmp -> cmpd for 64-bit
Date: Wed, 14 Dec 2016 03:02:56 -0800 [thread overview]
Message-ID: <20161214110256.GB5664@kroah.com> (raw)
In-Reply-To: <CACPK8Xf3X=bEj-EUXezYYEKNJwkqW4O0RiM2FcCtH4cNNxA-qw@mail.gmail.com>
On Wed, Dec 14, 2016 at 02:01:50PM +1030, Joel Stanley wrote:
> On Wed, Oct 26, 2016 at 8:51 PM, Michael Ellerman
> <patch-notifications@ellerman.id.au> wrote:
> > On Thu, 2016-06-10 at 13:42:19 UTC, Segher Boessenkool wrote:
> >> PowerPC's "cmp" instruction has four operands. Normally people write
> >> "cmpw" or "cmpd" for the second cmp operand 0 or 1. But, frequently
> >> people forget, and write "cmp" with just three operands.
> >>
> >> With older binutils this is silently accepted as if this was "cmpw",
> >> while often "cmpd" is wanted. With newer binutils GAS will complain
> >> about this for 64-bit code. For 32-bit code it still silently assumes
> >> "cmpw" is what is meant.
> >>
> >> Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org>
> >
> > Applied to powerpc fixes, thanks.
> >
> > I added:
> > Fixes: 948cf67c4726 ("powerpc: Add NAP mode support on Power7 in HV mode")
> > Cc: stable@vger.kernel.org # v3.0
> >
> > https://git.kernel.org/powerpc/c/80f23935cadb1c654e81951f5a8b7c
>
> This one made it into 4.9-rc3 as "powerpc: Convert cmp to cmpd in idle
> enter sequence". We need it to build the 4.4 kernel with GCC 6.2, so
> my OpenPower firmware builds are failing.
>
> The patch won't backport directly as in 4.4 the macro is in
> arch/powerpc/kernel/idle_power7.S.
>
> Greg, is this one in your queue? Do we need to send a patch to stable
> that backports cleanly?
I need a clean backport, that is why it never showed up in 4.4-stable.
thanks,
greg k-h
prev parent reply other threads:[~2016-12-14 11:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 13:42 [PATCH] powerpc: cmp -> cmpd for 64-bit Segher Boessenkool
2016-10-12 3:05 ` Michael Ellerman
2016-10-12 13:26 ` Segher Boessenkool
2016-10-12 17:00 ` Vaidyanathan Srinivasan
2016-10-26 10:21 ` Michael Ellerman
2016-12-14 3:31 ` Joel Stanley
2016-12-14 4:25 ` Segher Boessenkool
2016-12-14 11:02 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161214110256.GB5664@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amodra@gmail.com \
--cc=joel@jms.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=markus@trippelsdorf.de \
--cc=patch-notifications@ellerman.id.au \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.