From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Engestrom Subject: Re: [RESEND][PATCH] libkms/exynos: fix memory leak in error path Date: Wed, 14 Dec 2016 12:07:42 +0000 Message-ID: <20161214120742.GH29253@imgtec.com> References: <1479101494-12007-1-git-send-email-sw0312.kim@samsung.com> <1481703390-30045-1-git-send-email-sw0312.kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailapp01.imgtec.com (mailapp01.imgtec.com [195.59.15.196]) by gabe.freedesktop.org (Postfix) with ESMTP id C79E66E7CF for ; Wed, 14 Dec 2016 12:07:44 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1481703390-30045-1-git-send-email-sw0312.kim@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Seung-Woo Kim Cc: emil.l.velikov@gmail.com, robclark@freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkbmVzZGF5LCAyMDE2LTEyLTE0IDE3OjE2OjMwICswOTAwLCBTZXVuZy1Xb28gS2ltIHdy b3RlOgo+IFRoaXMgcGF0Y2ggZml4ZXMgbWVtb3J5IGxlYWsgaW4gZXJyb3IgcGF0aCBvZiBleHlu b3NfYm9fY3JlYXRlKCkuCgpJbmRlZWQsIHRoYW5rcyEKUmV2aWV3ZWQtYnk6IEVyaWMgRW5nZXN0 cm9tIDxlcmljLmVuZ2VzdHJvbUBpbWd0ZWMuY29tPgoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBTZXVu Zy1Xb28gS2ltIDxzdzAzMTIua2ltQHNhbXN1bmcuY29tPgo+IC0tLQo+ICBsaWJrbXMvZXh5bm9z LmMgfCAgICAzICsrLQo+ICAxIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvbGlia21zL2V4eW5vcy5jIGIvbGlia21zL2V4eW5v cy5jCj4gaW5kZXggNWRlMmU1YS4uMGU5N2ZiNSAxMDA2NDQKPiAtLS0gYS9saWJrbXMvZXh5bm9z LmMKPiArKysgYi9saWJrbXMvZXh5bm9zLmMKPiBAQCAtODgsNyArODgsOCBAQCBleHlub3NfYm9f Y3JlYXRlKHN0cnVjdCBrbXNfZHJpdmVyICprbXMsCj4gIAkJcGl0Y2ggPSAocGl0Y2ggKyA1MTIg LSAxKSAmIH4oNTEyIC0gMSk7Cj4gIAkJc2l6ZSA9IHBpdGNoICogKChoZWlnaHQgKyA0IC0gMSkg JiB+KDQgLSAxKSk7Cj4gIAl9IGVsc2Ugewo+IC0JCXJldHVybiAtRUlOVkFMOwo+ICsJCXJldCA9 IC1FSU5WQUw7Cj4gKwkJZ290byBlcnJfZnJlZTsKPiAgCX0KPiAgCj4gIAltZW1zZXQoJmFyZywg MCwgc2l6ZW9mKGFyZykpOwo+IC0tIAo+IDEuNy40LjEKPiAKCkhvd2V2ZXIsIEkgZmVlbCBsaWtl IGEgY2xlYW5lciBmaXggbWlnaHQgYmUgdG8gc2ltcGx5IG1vdmUgdGhlCmFsbG9jYXRpb24gdG8g d2hlcmUgaXQncyB1c2VkIGFuZCByZW1vdmUgdGhlIG5vdy11bm5lY2Vzc2FyeQplcnJvciBwYXRo LCBpZS46CgotLS0tODwtLS0tCmRpZmYgLS1naXQgYS9saWJrbXMvZXh5bm9zLmMgYi9saWJrbXMv ZXh5bm9zLmMKaW5kZXggNWRlMmU1YS4uZTJjMWM5ZiAxMDA2NDQKLS0tIGEvbGlia21zL2V4eW5v cy5jCisrKyBiL2xpYmttcy9leHlub3MuYwpAQCAtNzYsMTAgKzc2LDYgQEAgZXh5bm9zX2JvX2Ny ZWF0ZShzdHJ1Y3Qga21zX2RyaXZlciAqa21zLAogCQl9CiAJfQogCi0JYm8gPSBjYWxsb2MoMSwg c2l6ZW9mKCpibykpOwotCWlmICghYm8pCi0JCXJldHVybiAtRU5PTUVNOwotCiAJaWYgKHR5cGUg PT0gS01TX0JPX1RZUEVfQ1VSU09SXzY0WDY0X0E4UjhHOEI4KSB7CiAJCXBpdGNoID0gNjQgKiA0 OwogCQlzaXplID0gNjQgKiA2NCAqIDQ7CkBAIC05Niw3ICs5MiwxMSBAQCBleHlub3NfYm9fY3Jl YXRlKHN0cnVjdCBrbXNfZHJpdmVyICprbXMsCiAKIAlyZXQgPSBkcm1Db21tYW5kV3JpdGVSZWFk KGttcy0+ZmQsIERSTV9FWFlOT1NfR0VNX0NSRUFURSwgJmFyZywgc2l6ZW9mKGFyZykpOwogCWlm IChyZXQpCi0JCWdvdG8gZXJyX2ZyZWU7CisJCXJldHVybiByZXQ7CisKKwlibyA9IGNhbGxvYygx LCBzaXplb2YoKmJvKSk7CisJaWYgKCFibykKKwkJcmV0dXJuIC1FTk9NRU07CiAKIAliby0+YmFz ZS5rbXMgPSBrbXM7CiAJYm8tPmJhc2UuaGFuZGxlID0gYXJnLmhhbmRsZTsKQEAgLTEwNiwxMCAr MTA2LDYgQEAgZXh5bm9zX2JvX2NyZWF0ZShzdHJ1Y3Qga21zX2RyaXZlciAqa21zLAogCSpvdXQg PSAmYm8tPmJhc2U7CiAKIAlyZXR1cm4gMDsKLQotZXJyX2ZyZWU6Ci0JZnJlZShibyk7Ci0JcmV0 dXJuIHJldDsKIH0KIAogc3RhdGljIGludAotLS0tPjgtLS0tCgpCaWdnZXIgY2hhbmdlLCBidXQg Y2xlYW5lciBjb2RlIElNSE8uCldoYXQgZG8geW91IHRoaW5rPwoKQ2hlZXJzLAogIEVyaWMKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==