From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Engestrom Subject: Re: [RESEND][PATCH] libkms/exynos: fix memory leak in error path Date: Wed, 14 Dec 2016 13:12:22 +0000 Message-ID: <20161214131222.GI29253@imgtec.com> References: <1479101494-12007-1-git-send-email-sw0312.kim@samsung.com> <1481703390-30045-1-git-send-email-sw0312.kim@samsung.com> <20161214120742.GH29253@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailapp01.imgtec.com (mailapp01.imgtec.com [195.59.15.196]) by gabe.freedesktop.org (Postfix) with ESMTP id 3EBC16E7FA for ; Wed, 14 Dec 2016 13:12:24 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: Seung-Woo Kim , Rob Clark , ML dri-devel List-Id: dri-devel@lists.freedesktop.org T24gV2VkbmVzZGF5LCAyMDE2LTEyLTE0IDEyOjIxOjU1ICswMDAwLCBFbWlsIFZlbGlrb3Ygd3Jv dGU6Cj4gT24gMTQgRGVjZW1iZXIgMjAxNiBhdCAxMjowNywgRXJpYyBFbmdlc3Ryb20gPGVyaWMu ZW5nZXN0cm9tQGltZ3RlYy5jb20+IHdyb3RlOgo+ID4gT24gV2VkbmVzZGF5LCAyMDE2LTEyLTE0 IDE3OjE2OjMwICswOTAwLCBTZXVuZy1Xb28gS2ltIHdyb3RlOgo+ID4+IFRoaXMgcGF0Y2ggZml4 ZXMgbWVtb3J5IGxlYWsgaW4gZXJyb3IgcGF0aCBvZiBleHlub3NfYm9fY3JlYXRlKCkuCj4gPgo+ ID4gSW5kZWVkLCB0aGFua3MhCj4gPiBSZXZpZXdlZC1ieTogRXJpYyBFbmdlc3Ryb20gPGVyaWMu ZW5nZXN0cm9tQGltZ3RlYy5jb20+Cj4gPgo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogU2V1bmct V29vIEtpbSA8c3cwMzEyLmtpbUBzYW1zdW5nLmNvbT4KPiA+PiAtLS0KPiA+PiAgbGlia21zL2V4 eW5vcy5jIHwgICAgMyArKy0KPiA+PiAgMSBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyks IDEgZGVsZXRpb25zKC0pCj4gPj4KPiA+PiBkaWZmIC0tZ2l0IGEvbGlia21zL2V4eW5vcy5jIGIv bGlia21zL2V4eW5vcy5jCj4gPj4gaW5kZXggNWRlMmU1YS4uMGU5N2ZiNSAxMDA2NDQKPiA+PiAt LS0gYS9saWJrbXMvZXh5bm9zLmMKPiA+PiArKysgYi9saWJrbXMvZXh5bm9zLmMKPiA+PiBAQCAt ODgsNyArODgsOCBAQCBleHlub3NfYm9fY3JlYXRlKHN0cnVjdCBrbXNfZHJpdmVyICprbXMsCj4g Pj4gICAgICAgICAgICAgICBwaXRjaCA9IChwaXRjaCArIDUxMiAtIDEpICYgfig1MTIgLSAxKTsK PiA+PiAgICAgICAgICAgICAgIHNpemUgPSBwaXRjaCAqICgoaGVpZ2h0ICsgNCAtIDEpICYgfig0 IC0gMSkpOwo+ID4+ICAgICAgIH0gZWxzZSB7Cj4gPj4gLSAgICAgICAgICAgICByZXR1cm4gLUVJ TlZBTDsKPiA+PiArICAgICAgICAgICAgIHJldCA9IC1FSU5WQUw7Cj4gPj4gKyAgICAgICAgICAg ICBnb3RvIGVycl9mcmVlOwo+ID4+ICAgICAgIH0KPiA+Pgo+ID4+ICAgICAgIG1lbXNldCgmYXJn LCAwLCBzaXplb2YoYXJnKSk7Cj4gPj4gLS0KPiA+PiAxLjcuNC4xCj4gPj4KPiA+Cj4gPiBIb3dl dmVyLCBJIGZlZWwgbGlrZSBhIGNsZWFuZXIgZml4IG1pZ2h0IGJlIHRvIHNpbXBseSBtb3ZlIHRo ZQo+ID4gYWxsb2NhdGlvbiB0byB3aGVyZSBpdCdzIHVzZWQgYW5kIHJlbW92ZSB0aGUgbm93LXVu bmVjZXNzYXJ5Cj4gPiBlcnJvciBwYXRoLCBpZS46Cj4gPgo+ID4gLS0tLTg8LS0tLQo+ID4gZGlm ZiAtLWdpdCBhL2xpYmttcy9leHlub3MuYyBiL2xpYmttcy9leHlub3MuYwo+ID4gaW5kZXggNWRl MmU1YS4uZTJjMWM5ZiAxMDA2NDQKPiA+IC0tLSBhL2xpYmttcy9leHlub3MuYwo+ID4gKysrIGIv bGlia21zL2V4eW5vcy5jCj4gPiBAQCAtNzYsMTAgKzc2LDYgQEAgZXh5bm9zX2JvX2NyZWF0ZShz dHJ1Y3Qga21zX2RyaXZlciAqa21zLAo+ID4gICAgICAgICAgICAgICAgIH0KPiA+ICAgICAgICAg fQo+ID4KPiA+IC0gICAgICAgYm8gPSBjYWxsb2MoMSwgc2l6ZW9mKCpibykpOwo+ID4gLSAgICAg ICBpZiAoIWJvKQo+ID4gLSAgICAgICAgICAgICAgIHJldHVybiAtRU5PTUVNOwo+ID4gLQo+ID4g ICAgICAgICBpZiAodHlwZSA9PSBLTVNfQk9fVFlQRV9DVVJTT1JfNjRYNjRfQThSOEc4QjgpIHsK PiA+ICAgICAgICAgICAgICAgICBwaXRjaCA9IDY0ICogNDsKPiA+ICAgICAgICAgICAgICAgICBz aXplID0gNjQgKiA2NCAqIDQ7Cj4gPiBAQCAtOTYsNyArOTIsMTEgQEAgZXh5bm9zX2JvX2NyZWF0 ZShzdHJ1Y3Qga21zX2RyaXZlciAqa21zLAo+ID4KPiA+ICAgICAgICAgcmV0ID0gZHJtQ29tbWFu ZFdyaXRlUmVhZChrbXMtPmZkLCBEUk1fRVhZTk9TX0dFTV9DUkVBVEUsICZhcmcsIHNpemVvZihh cmcpKTsKPiA+ICAgICAgICAgaWYgKHJldCkKPiA+IC0gICAgICAgICAgICAgICBnb3RvIGVycl9m cmVlOwo+ID4gKyAgICAgICAgICAgICAgIHJldHVybiByZXQ7Cj4gPiArCj4gPiArICAgICAgIGJv ID0gY2FsbG9jKDEsIHNpemVvZigqYm8pKTsKPiA+ICsgICAgICAgaWYgKCFibykKPiBIZXJlIHdl J3JlIG1pc3NpbmcgdGhlIGRybUlvY3RsKC4uLiBEUk1fSU9DVExfR0VNX0NMT1NFIC4uLikKCllv dSdyZSByaWdodC4uLiBJJ20gbm90IGFjdHVhbGx5IGltcHJvdmluZyBhbnl0aGluZyB3aXRoIG15 IHN1Z2dlc3Rpb24uCgo+IAo+IEFub3RoZXIgc29sdXRpb24gaXMgdG8gbW92ZSBzaXplL3BpdGNo IGNhbGN1bGF0aW9uIGJlZm9yZSB0aGUgY2FsbG9jLgo+IE5vdCBzdXJlIHdoaWNoIG9uZSB3aWxs IGJlIGJldHRlciB0aG91Z2guCgpMZXQncyBqdXN0IGxhbmQgU2V1bmctV29vJ3MgZml4PwpXZSBj YW4gYWx3YXlzIHJlZmFjdG9yIGxhdGVyIDopCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=