From: Eric Biggers <ebiggers3@gmail.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Eric Biggers <ebiggers@google.com>,
fstests@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Richard Weinberger <richard@nod.at>,
David Gstir <david@sigma-star.at>,
Michael Halcrow <mhalcrow@google.com>
Subject: Re: [PATCH v3 0/6] Add filesystem-level encryption tests
Date: Wed, 14 Dec 2016 16:31:38 -0800 [thread overview]
Message-ID: <20161215003138.GB18462@gmail.com> (raw)
In-Reply-To: <20161213061255.GP29149@eguan.usersys.redhat.com>
On Tue, Dec 13, 2016 at 02:12:55PM +0800, Eryu Guan wrote:
> On Mon, Dec 05, 2016 at 11:21:03AM -0800, Eric Biggers wrote:
> > This is the third version of the patch series to add some xfstests for
> > filesystem-level encryption. The new tests are designed to run on any
> > filesystem that implements the "fscrypt" API, currently ext4 and f2fs.
> > (fscrypt support for ubifs is also under development, but it looks like
> > xfstests doesn't have ubifs support yet.)
> >
> > The new tests are designed to complement, not replace, doing a full
> > xfstests run with encryption enabled, which for ext4 can currently be
> > done by using the test_dummy_encryption mount option.
>
> These tests look good to me now overall, from fstests perspective of
> view. I tested them with 4.9 kernel with ext4 encryption enabled, latest
> e2fsprogs and latest xfsprogs plus the set|get_policy patch. All tests
> passed on ext4. Comments go to individual patch.
>
> But I'm not so familiar with this new encryption API, it would be good
> to have some reviews on the tests from other fscrypt developers too.
>
Hi Eryu, thanks for the review. I'm planning to send a v4 of the patchset to
address your comments.
I've let people with more involvement in filesystem encryption know that this
needs to be reviewed. (And some are Cc'ed here; Ted and Jaegeuk are the
official fscrypto maintainers.)
Thanks,
Eric
prev parent reply other threads:[~2016-12-15 0:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 19:21 [PATCH v3 0/6] Add filesystem-level encryption tests Eric Biggers
2016-12-05 19:21 ` [PATCH v3 1/6] generic: add utilities for testing filesystem encryption Eric Biggers
2016-12-13 5:41 ` Eryu Guan
2016-12-13 7:05 ` Darrick J. Wong
2016-12-05 19:21 ` [PATCH v3 2/6] generic: test setting and getting encryption policies Eric Biggers
2016-12-13 5:59 ` Eryu Guan
2016-12-05 19:21 ` [PATCH v3 3/6] generic: test validation of encryption policy structure Eric Biggers
2016-12-05 19:21 ` [PATCH v3 4/6] generic: test encrypted file access Eric Biggers
2016-12-05 19:21 ` [PATCH v3 5/6] generic: test enforcement of one encryption policy per tree Eric Biggers
2016-12-13 6:07 ` Eryu Guan
2016-12-05 19:21 ` [PATCH v3 6/6] generic: test for weaknesses in filesystem encryption Eric Biggers
2016-12-13 6:12 ` [PATCH v3 0/6] Add filesystem-level encryption tests Eryu Guan
2016-12-15 0:31 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161215003138.GB18462@gmail.com \
--to=ebiggers3@gmail.com \
--cc=david@sigma-star.at \
--cc=ebiggers@google.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=jaegeuk@kernel.org \
--cc=mhalcrow@google.com \
--cc=richard@nod.at \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.