From: "Michael S. Tsirkin" <mst@redhat.com>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: netdev@vger.kernel.org, kvm@vger.kernel.org,
Stefan Hajnoczi <stefanha@redhat.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] vhost/vsock: Remove unused but set variable
Date: Thu, 15 Dec 2016 06:54:58 +0200 [thread overview]
Message-ID: <20161215065447-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20161111132631.25708-1-tklauser@distanz.ch>
On Fri, Nov 11, 2016 at 02:26:31PM +0100, Tobias Klauser wrote:
> Remove the unused but set variable vq in vhost_transport_send_pkt() to
> fix the following GCC warning when building with 'W=1':
>
> drivers/vhost/vsock.c:198:26: warning: variable ‘vq’ set but not used
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
doesn't apply anymore.
> ---
> drivers/vhost/vsock.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
> index e3b30ea9ece5..9c3c68b9a49e 100644
> --- a/drivers/vhost/vsock.c
> +++ b/drivers/vhost/vsock.c
> @@ -195,7 +195,6 @@ static int
> vhost_transport_send_pkt(struct virtio_vsock_pkt *pkt)
> {
> struct vhost_vsock *vsock;
> - struct vhost_virtqueue *vq;
> int len = pkt->len;
>
> /* Find the vhost_vsock according to guest context id */
> @@ -205,8 +204,6 @@ vhost_transport_send_pkt(struct virtio_vsock_pkt *pkt)
> return -ENODEV;
> }
>
> - vq = &vsock->vqs[VSOCK_VQ_RX];
> -
> if (pkt->reply)
> atomic_inc(&vsock->queued_replies);
>
> --
> 2.11.0.rc0.7.gbe5a750
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2016-12-15 4:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 13:26 [PATCH] vhost/vsock: Remove unused but set variable Tobias Klauser
2016-11-15 13:00 ` Stefan Hajnoczi
2016-11-15 13:00 ` Stefan Hajnoczi
2016-12-15 4:54 ` Michael S. Tsirkin [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-11-11 13:26 Tobias Klauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161215065447-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefanha@redhat.com \
--cc=tklauser@distanz.ch \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.