From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH 17/32] net/dpaa2: dpbp based mempool hw
	offload driver
Date: Thu, 15 Dec 2016 12:24:54 +0530
Message-ID: <20161215065453.GA23329@localhost.localdomain>
References: <1480875447-23680-1-git-send-email-hemant.agrawal@nxp.com>
 <1480875447-23680-18-git-send-email-hemant.agrawal@nxp.com>
 <20161215060927.GB19354@localhost.localdomain>
 <8a6fe787-f8e6-e326-c1b9-42b001644885@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>, <dev@dpdk.org>,
 <thomas.monjalon@6wind.com>, <bruce.richardson@intel.com>
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0071.outbound.protection.outlook.com [104.47.32.71])
 by dpdk.org (Postfix) with ESMTP id 08D4710A7
 for <dev@dpdk.org>; Thu, 15 Dec 2016 07:55:16 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <8a6fe787-f8e6-e326-c1b9-42b001644885@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Dec 15, 2016 at 12:07:51PM +0530, Shreyansh Jain wrote:
> On Thursday 15 December 2016 11:39 AM, Jerin Jacob wrote:
> > On Sun, Dec 04, 2016 at 11:47:12PM +0530, Hemant Agrawal wrote:
> > > DPBP represent a buffer pool instance in DPAA2-QBMAN
> > > HW accelerator.
> > > 
> > > All buffers needs to be programmed in the HW accelerator.
> > > 
> > > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > > ---
> > >  config/defconfig_arm64-dpaa2-linuxapp-gcc |   5 +
> > >  drivers/net/dpaa2/Makefile                |   2 +
> > >  drivers/net/dpaa2/base/dpaa2_hw_dpbp.c    | 366 ++++++++++++++++++++++++++++++
> > >  drivers/net/dpaa2/base/dpaa2_hw_dpbp.h    | 101 +++++++++
> > >  drivers/net/dpaa2/base/dpaa2_hw_pvt.h     |   7 +
> > 
> > 
> > How about moving the external mempool driver to RTE_SDK/driver/pool.
> > We are planning to push our external mempool driver to driver/pool.
> 
> I really like the idea of this separation:
> 
> So,
> ..drivers/net/<all PMDs>
> ..drivers/crypto/<all crypto PMDs>
> ..drivers/bus/<all bus handlers/drivers>
> ..drivers/pool/<all Pool handlers/drivers>
> 
> only concern I see for now is resolving dependency of symbols across this
> structure. for example, DPAA2 Pool would be dependent on some DPAA2 specific
> objects - which then are again used in crypto/ and net/.
> 
> It is possible to have drivers/common (which DPAA2 PMD patchset is already
> doing). How are you doing that?

Same approach. driver/common/octeontx directory for common octeontx driver code