Re: [Qemu-devel] [RFC PATCH v2 0/8] VMS_ARRAY_OF_POINTER with null pointers

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Halil Pasic (pasic@linux.vnet.ibm.com) wrote:
> Make VMS_ARRAY_OF_POINTER cope with null pointers. Currently the reward
> for trying to migrate an array with some null pointers in it is an
> illegal memory access, that is a swift and painless death of the
> process. Let's make vmstate cope with this scenario at least for
> pointers to structs.
> 
> Halil Pasic (7):
>   migration: drop unused VMStateField.start

Note that Jianjun uses .start in the QTAILQ migration series.

Dave

>   tests/test-vmstate.c: add save_buffer util func
>   tests/test-vmstate.c: add array of pointer to struct
>   migration/vmstate: renames in (load|save)_state
>   migration/vmstate: split up vmstate_base_addr
>   migration/vmstate: fix array of pointers to struct
>   tests/test-vmstate.c: add array of pointers to struct with NULL
> 
>  hw/char/exynos4210_uart.c   |   2 +-
>  hw/display/g364fb.c         |   2 +-
>  hw/dma/pl330.c              |   8 +-
>  hw/intc/exynos4210_gic.c    |   2 +-
>  hw/ipmi/isa_ipmi_bt.c       |   4 +-
>  hw/ipmi/isa_ipmi_kcs.c      |   4 +-
>  hw/net/vmxnet3.c            |   2 +-
>  hw/nvram/mac_nvram.c        |   2 +-
>  hw/nvram/spapr_nvram.c      |   2 +-
>  hw/sd/sdhci.c               |   2 +-
>  hw/timer/m48t59.c           |   2 +-
>  include/migration/vmstate.h |  27 +++--
>  migration/savevm.c          |   2 +-
>  migration/vmstate.c         |  91 ++++++++++------
>  target-s390x/machine.c      |   2 +-
>  tests/test-vmstate.c        | 250 +++++++++++++++++++++++++++++++++++++++++---
>  util/fifo8.c                |   2 +-
>  17 files changed, 327 insertions(+), 79 deletions(-)
> 
> -- 
> 2.8.4
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK