From: Petr Mladek <pmladek@suse.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Joe Perches <joe@perches.com>,
Steven Rostedt <rostedt@goodmis.org>,
Mark Rutland <mark.rutland@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: Remove no longer used second struct cont
Date: Thu, 15 Dec 2016 17:23:37 +0100 [thread overview]
Message-ID: <20161215162336.GA18152@pathway.suse.cz> (raw)
In-Reply-To: <1481806438-30185-1-git-send-email-geert@linux-m68k.org>
On Thu 2016-12-15 13:53:58, Geert Uytterhoeven wrote:
> If CONFIG_PRINTK=n:
>
> kernel/printk/printk.c:1893: warning: ‘cont’ defined but not used
>
> Note that there are actually two different struct cont definitions and
> objects: the first one is used if CONFIG_PRINTK=y, the second one became
> unused by removing console_cont_flush().
>
> Fixes: 5c2992ee7fd8a29d ("printk: remove console flushing special cases for partial buffered lines")
Great catch. It seems that nobody tried the build without CONFIG_PRINTK
at that time.
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2016-12-15 16:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 12:53 [PATCH] printk: Remove no longer used second struct cont Geert Uytterhoeven
2016-12-15 16:23 ` Petr Mladek [this message]
2016-12-16 1:37 ` Sergey Senozhatsky
2016-12-16 1:39 ` Joe Perches
2016-12-16 1:50 ` Sergey Senozhatsky
2016-12-16 1:50 ` Linus Torvalds
2016-12-16 1:57 ` Joe Perches
2016-12-16 2:10 ` Linus Torvalds
2016-12-16 2:30 ` Joe Perches
2016-12-16 5:00 ` Junio C Hamano
2016-12-16 6:04 ` Joe Perches
2016-12-16 6:04 ` Joe Perches
2016-12-16 2:00 ` Sergey Senozhatsky
2016-12-18 19:29 ` Scott Matheina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161215162336.GA18152@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.