From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: "Hefty, Sean" <sean.hefty@intel.com>
Cc: "Vishwanathapura,
Niranjana" <niranjana.vishwanathapura@intel.com>,
"dledford@redhat.com" <dledford@redhat.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Dalessandro, Dennis" <dennis.dalessandro@intel.com>,
"Weiny, Ira" <ira.weiny@intel.com>,
"Warrier, Sadanand" <sadanand.warrier@intel.com>,
"Dutt, Sudeep" <sudeep.dutt@intel.com>,
"Jajodia, Tanya K" <tanya.k.jajodia@intel.com>,
"Kacprowski, Andrzej" <Andrzej.Kacprowski@intel.com>
Subject: Re: [RFC v2 03/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) netdev
Date: Thu, 15 Dec 2016 10:24:37 -0700 [thread overview]
Message-ID: <20161215172437.GA11387@obsidianresearch.com> (raw)
In-Reply-To: <1828884A29C6694DAF28B7E6B8A82373AB0C9556@ORSMSX109.amr.corp.intel.com>
On Thu, Dec 15, 2016 at 05:21:05PM +0000, Hefty, Sean wrote:
> > This goes on the network too? Also looks like it has endian problems.
>
> I don't think OPA supports BE systems, and I think it uses LE on the
> wire for at least some portions of its protocol.
This is a linux driver for a PCI device.
It needs to support big endian systems, that is how we do things in
Linux.
If it uses LE on the wire then mark with __le and make it sparse clean.
Do not use bitfields without providing a BE version of the bitfield.
Jason
next prev parent reply other threads:[~2016-12-15 17:24 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 7:59 [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC) Vishwanathapura, Niranjana
2016-12-15 7:59 ` [RFC v2 01/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) documentation Vishwanathapura, Niranjana
2016-12-15 7:59 ` [RFC v2 05/10] IB/hfi-vnic: VNIC statistics support Vishwanathapura, Niranjana
2016-12-15 7:59 ` [RFC v2 08/10] IB/hfi-vnic: VNIC Ethernet Management Agent (VEMA) function Vishwanathapura, Niranjana
2016-12-15 7:59 ` [RFC v2 09/10] IB/hfi1: Virtual Network Interface Controller (VNIC) support Vishwanathapura, Niranjana
2016-12-15 7:59 ` [RFC v2 10/10] IB/hfi1: VNIC SDMA support Vishwanathapura, Niranjana
[not found] ` <1481788782-89964-1-git-send-email-niranjana.vishwanathapura-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-12-15 7:59 ` [RFC v2 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) interface Vishwanathapura, Niranjana
[not found] ` <1481788782-89964-3-git-send-email-niranjana.vishwanathapura-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-12-15 8:53 ` Vishwanathapura, Niranjana
[not found] ` <20161215085349.GA90068-wPcXA7LoDC+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2016-12-15 8:56 ` Christoph Hellwig
2016-12-15 17:36 ` Stephen Hemminger
2016-12-15 7:59 ` [RFC v2 03/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) netdev Vishwanathapura, Niranjana
[not found] ` <1481788782-89964-4-git-send-email-niranjana.vishwanathapura-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-12-15 17:01 ` Jason Gunthorpe
2016-12-15 17:21 ` Hefty, Sean
2016-12-15 17:24 ` Jason Gunthorpe [this message]
2016-12-15 17:26 ` Christoph Hellwig
[not found] ` <20161215170109.GC3264-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-12-16 2:59 ` Vishwanathapura, Niranjana
2016-12-16 4:24 ` Jason Gunthorpe
[not found] ` <20161216042420.GB3797-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-12-19 6:43 ` Vishwanathapura, Niranjana
2016-12-15 7:59 ` [RFC v2 04/10] IB/hfi-vnic: VNIC Ethernet Management (EM) structure definitions Vishwanathapura, Niranjana
2016-12-15 7:59 ` [RFC v2 06/10] IB/hfi-vnic: VNIC MAC table support Vishwanathapura, Niranjana
2016-12-15 7:59 ` [RFC v2 07/10] IB/hfi-vnic: VNIC Ethernet Management Agent (VEMA) interface Vishwanathapura, Niranjana
2016-12-15 9:12 ` [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC) Leon Romanovsky
[not found] ` <20161215091226.GC811-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2016-12-15 14:52 ` ira.weiny
[not found] ` <20161215145212.GA29116-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2016-12-15 16:28 ` Doug Ledford
[not found] ` <380b05bf-a18e-1f20-7e8e-10b61f77dec7-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-12-15 17:07 ` Jason Gunthorpe
2016-12-15 18:19 ` Doug Ledford
[not found] ` <4e22bf29-2260-0768-ab17-9a8df6306f37-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-12-15 18:48 ` Jason Gunthorpe
[not found] ` <20161215184837.GA16552-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-12-16 1:24 ` ira.weiny
[not found] ` <20161216012404.GD3785-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2016-12-16 2:30 ` Vishwanathapura, Niranjana
2016-12-16 4:17 ` Jason Gunthorpe
2017-01-17 19:27 ` Vishwanathapura, Niranjana
[not found] ` <20170117192720.GA2833-wPcXA7LoDC+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2017-01-18 5:43 ` Leon Romanovsky
2017-01-18 16:46 ` Jason Gunthorpe
[not found] ` <20161215170713.GD3264-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-12-16 2:47 ` Vishwanathapura, Niranjana
2017-01-09 7:51 ` Leon Romanovsky
[not found] ` <20170109075104.GV15685-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-01-10 3:39 ` Vishwanathapura, Niranjana
[not found] ` <20170110033954.GA53664-wPcXA7LoDC+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2017-01-10 8:14 ` Leon Romanovsky
[not found] ` <20170110081402.GH7218-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-01-11 9:05 ` Vishwanathapura, Niranjana
2017-01-11 9:16 ` Leon Romanovsky
2016-12-15 16:56 ` Jason Gunthorpe
[not found] ` <20161215165611.GB3264-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-12-16 4:14 ` Vishwanathapura, Niranjana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161215172437.GA11387@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=Andrzej.Kacprowski@intel.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=ira.weiny@intel.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niranjana.vishwanathapura@intel.com \
--cc=sadanand.warrier@intel.com \
--cc=sean.hefty@intel.com \
--cc=sudeep.dutt@intel.com \
--cc=tanya.k.jajodia@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.