From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.25.205.13 with SMTP id d13csp190688lfg; Thu, 15 Dec 2016 08:38:46 -0800 (PST) X-Received: by 10.237.32.228 with SMTP id 91mr1585659qtb.146.1481819926863; Thu, 15 Dec 2016 08:38:46 -0800 (PST) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [208.118.235.17]) by mx.google.com with ESMTPS id k41si1200655qkh.316.2016.12.15.08.38.46 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 15 Dec 2016 08:38:46 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Received: from localhost ([::1]:55675 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHZ3M-0000CE-74 for alex.bennee@linaro.org; Thu, 15 Dec 2016 11:38:44 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHZ3E-0008PW-6i for qemu-arm@nongnu.org; Thu, 15 Dec 2016 11:38:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cHZ3B-0002Xi-2C for qemu-arm@nongnu.org; Thu, 15 Dec 2016 11:38:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55914) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cHZ3A-0002XC-Sd; Thu, 15 Dec 2016 11:38:32 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E11523D96D; Thu, 15 Dec 2016 16:38:31 +0000 (UTC) Received: from redhat.com (ovpn-118-90.rdu2.redhat.com [10.10.118.90]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with SMTP id uBFGcUAp028399; Thu, 15 Dec 2016 11:38:30 -0500 Date: Thu, 15 Dec 2016 18:38:30 +0200 From: "Michael S. Tsirkin" To: Andrew Jones Message-ID: <20161215183759-mutt-send-email-mst@kernel.org> References: <20161213214522.25548-1-drjones@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161213214522.25548-1-drjones@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 15 Dec 2016 16:38:31 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-arm] [PATCH 00/11] Remove VirtGuestInfo X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, ehabkost@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, zhaoshenglong@huawei.com, imammedo@redhat.com Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: yMKtriTz7Tsy On Tue, Dec 13, 2016 at 10:45:11PM +0100, Andrew Jones wrote: > This series is based on Peter's qemu-arm gicv3-virt branch. It's > main goal (patches 04-10), which was suggested by Eduardo, is to > remove an unnecessary structure, VirtGuestInfo, which is a > maintenance burden, as it requires duplicating Virt machine state. > Additionally patches 01-03 do some mach-virt cleanups and patch 11 > adds the ACPI equivalent to one of the DT patches in Peter's > gicv3-virt branch. > > The last patch isn't really tested as the guest kernel versions I > used seem to ignore the GTDT irqflags and either just choose edge, > 4.5-based kernel, or level, 4.9-based kernel. > > Patches available here > https://github.com/rhdrjones/qemu/commits/virt/remove-guest-info I like this in general. Acked-by: Michael S. Tsirkin Pls merge through the ARM tree. > > Andrew Jones (11): > hw/arm/virt: parameter passing cleanups > hw/arm/virt: use VirtMachineState.gic_version > hw/arm/virt: use VirtMachineState.smp_cpus > hw/arm/virt: eliminate struct VirtGuestInfoState > hw/arm/virt: remove include/hw/arm/virt-acpi-build.h > hw/arm/virt: move VirtMachineState/Class to virt.h > hw/arm/virt: pass VirtMachineState instead of VirtGuestInfo > hw/arm/virt-acpi-build: remove redundant members from VirtGuestInfo > hw/arm/virt-acpi-build: don't save VirtGuestInfo on AcpiBuildState > hw/arm/virt: remove VirtGuestInfo > hw/arm/virt-acpi-build: Don't incorrectly claim architectural timer to > be edge-triggered > > MAINTAINERS | 2 - > hw/arm/virt-acpi-build.c | 103 +++++++++++++------------- > hw/arm/virt.c | 152 ++++++++++++++------------------------- > include/hw/arm/virt-acpi-build.h | 47 ------------ > include/hw/arm/virt.h | 45 +++++++++++- > 5 files changed, 151 insertions(+), 198 deletions(-) > delete mode 100644 include/hw/arm/virt-acpi-build.h > > -- > 2.9.3 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHZ3G-00008Z-Gi for qemu-devel@nongnu.org; Thu, 15 Dec 2016 11:38:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cHZ3F-0002Zx-JF for qemu-devel@nongnu.org; Thu, 15 Dec 2016 11:38:38 -0500 Date: Thu, 15 Dec 2016 18:38:30 +0200 From: "Michael S. Tsirkin" Message-ID: <20161215183759-mutt-send-email-mst@kernel.org> References: <20161213214522.25548-1-drjones@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161213214522.25548-1-drjones@redhat.com> Subject: Re: [Qemu-devel] [PATCH 00/11] Remove VirtGuestInfo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org, zhaoshenglong@huawei.com, imammedo@redhat.com, ehabkost@redhat.com On Tue, Dec 13, 2016 at 10:45:11PM +0100, Andrew Jones wrote: > This series is based on Peter's qemu-arm gicv3-virt branch. It's > main goal (patches 04-10), which was suggested by Eduardo, is to > remove an unnecessary structure, VirtGuestInfo, which is a > maintenance burden, as it requires duplicating Virt machine state. > Additionally patches 01-03 do some mach-virt cleanups and patch 11 > adds the ACPI equivalent to one of the DT patches in Peter's > gicv3-virt branch. > > The last patch isn't really tested as the guest kernel versions I > used seem to ignore the GTDT irqflags and either just choose edge, > 4.5-based kernel, or level, 4.9-based kernel. > > Patches available here > https://github.com/rhdrjones/qemu/commits/virt/remove-guest-info I like this in general. Acked-by: Michael S. Tsirkin Pls merge through the ARM tree. > > Andrew Jones (11): > hw/arm/virt: parameter passing cleanups > hw/arm/virt: use VirtMachineState.gic_version > hw/arm/virt: use VirtMachineState.smp_cpus > hw/arm/virt: eliminate struct VirtGuestInfoState > hw/arm/virt: remove include/hw/arm/virt-acpi-build.h > hw/arm/virt: move VirtMachineState/Class to virt.h > hw/arm/virt: pass VirtMachineState instead of VirtGuestInfo > hw/arm/virt-acpi-build: remove redundant members from VirtGuestInfo > hw/arm/virt-acpi-build: don't save VirtGuestInfo on AcpiBuildState > hw/arm/virt: remove VirtGuestInfo > hw/arm/virt-acpi-build: Don't incorrectly claim architectural timer to > be edge-triggered > > MAINTAINERS | 2 - > hw/arm/virt-acpi-build.c | 103 +++++++++++++------------- > hw/arm/virt.c | 152 ++++++++++++++------------------------- > include/hw/arm/virt-acpi-build.h | 47 ------------ > include/hw/arm/virt.h | 45 +++++++++++- > 5 files changed, 151 insertions(+), 198 deletions(-) > delete mode 100644 include/hw/arm/virt-acpi-build.h > > -- > 2.9.3