From: Peter Zijlstra <peterz@infradead.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>,
David Laight <David.Laight@aculab.com>,
Netdev <netdev@vger.kernel.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
Jean-Philippe Aumasson <jeanphilippe.aumasson@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
"Daniel J . Bernstein" <djb@cr.yp.to>,
Linus Torvalds <torvalds@linux-foundation.org>,
Eric Biggers <ebiggers3@gmail.com>
Subject: [kernel-hardening] Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function
Date: Thu, 15 Dec 2016 22:09:33 +0100 [thread overview]
Message-ID: <20161215210933.GY3207@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CAHmME9pTLFu3-4n6m_OMj5jVWGE-+yC-4CnkynD--H4Nt8_cpA@mail.gmail.com>
On Thu, Dec 15, 2016 at 07:50:36PM +0100, Jason A. Donenfeld wrote:
> There's no 32-bit platform
> that will trap on a 64-bit unaligned access because there's no such
> thing as a 64-bit access there. In short, we're fine.
ARMv7 LPAE is a 32bit architecture that has 64bit load/stores IIRC.
x86 has cmpxchg8b that can do 64bit things and very much wants the u64
aligned.
Also, IIRC we have a few platforms where u64 doesn't carry 8 byte
alignment, m68k or something like that, but yes, you likely don't care.
Just to make life interesting...
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>,
David Laight <David.Laight@aculab.com>,
Netdev <netdev@vger.kernel.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
Jean-Philippe Aumasson <jeanphilippe.aumasson@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
"Daniel J . Bernstein" <djb@cr.yp.to>,
Linus Torvalds <torvalds@linux-foundation.org>,
Eric Biggers <ebiggers3@gmail.com>
Subject: Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function
Date: Thu, 15 Dec 2016 22:09:33 +0100 [thread overview]
Message-ID: <20161215210933.GY3207@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CAHmME9pTLFu3-4n6m_OMj5jVWGE-+yC-4CnkynD--H4Nt8_cpA@mail.gmail.com>
On Thu, Dec 15, 2016 at 07:50:36PM +0100, Jason A. Donenfeld wrote:
> There's no 32-bit platform
> that will trap on a 64-bit unaligned access because there's no such
> thing as a 64-bit access there. In short, we're fine.
ARMv7 LPAE is a 32bit architecture that has 64bit load/stores IIRC.
x86 has cmpxchg8b that can do 64bit things and very much wants the u64
aligned.
Also, IIRC we have a few platforms where u64 doesn't carry 8 byte
alignment, m68k or something like that, but yes, you likely don't care.
Just to make life interesting...
next prev parent reply other threads:[~2016-12-15 21:09 UTC|newest]
Thread overview: 143+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 3:59 [kernel-hardening] [PATCH v2 1/4] siphash: add cryptographically secure hashtable function Jason A. Donenfeld
2016-12-14 3:59 ` Jason A. Donenfeld
2016-12-14 3:59 ` [kernel-hardening] [PATCH v2 2/4] siphash: add convenience functions for jhash converts Jason A. Donenfeld
2016-12-14 3:59 ` Jason A. Donenfeld
2016-12-14 3:59 ` [kernel-hardening] [PATCH v2 3/4] secure_seq: use siphash24 instead of md5_transform Jason A. Donenfeld
2016-12-14 3:59 ` Jason A. Donenfeld
2016-12-14 12:53 ` [kernel-hardening] " Jason A. Donenfeld
2016-12-14 12:53 ` Jason A. Donenfeld
2016-12-14 13:16 ` [kernel-hardening] " Hannes Frederic Sowa
2016-12-14 13:16 ` Hannes Frederic Sowa
2016-12-14 13:44 ` [kernel-hardening] " Jason A. Donenfeld
2016-12-14 13:44 ` Jason A. Donenfeld
2016-12-14 14:47 ` [kernel-hardening] " David Laight
2016-12-14 14:47 ` David Laight
2016-12-14 17:49 ` [kernel-hardening] " Jason A. Donenfeld
2016-12-14 17:49 ` Jason A. Donenfeld
2016-12-14 17:56 ` [kernel-hardening] " David Miller
2016-12-14 17:56 ` David Miller
2016-12-14 18:06 ` [kernel-hardening] " Jason A. Donenfeld
2016-12-14 18:06 ` Jason A. Donenfeld
2016-12-14 19:22 ` [kernel-hardening] " Hannes Frederic Sowa
2016-12-14 19:22 ` Hannes Frederic Sowa
2016-12-14 19:38 ` [kernel-hardening] " Jason A. Donenfeld
2016-12-14 19:38 ` Jason A. Donenfeld
2016-12-14 20:27 ` [kernel-hardening] " Hannes Frederic Sowa
2016-12-14 20:27 ` Hannes Frederic Sowa
2016-12-14 20:12 ` [kernel-hardening] " Tom Herbert
2016-12-14 20:12 ` Tom Herbert
2016-12-14 21:01 ` [kernel-hardening] " Jason A. Donenfeld
2016-12-14 21:01 ` Jason A. Donenfeld
2016-12-14 3:59 ` [kernel-hardening] [PATCH v2 4/4] random: use siphash24 instead of md5 for get_random_int/long Jason A. Donenfeld
2016-12-14 3:59 ` Jason A. Donenfeld
2016-12-14 11:21 ` [kernel-hardening] Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function Hannes Frederic Sowa
2016-12-14 11:21 ` Hannes Frederic Sowa
2016-12-14 13:10 ` [kernel-hardening] " Jason A. Donenfeld
2016-12-14 13:10 ` Jason A. Donenfeld
2016-12-14 15:09 ` [kernel-hardening] " Hannes Frederic Sowa
2016-12-14 15:09 ` Hannes Frederic Sowa
2016-12-14 19:47 ` [kernel-hardening] " Jason A. Donenfeld
2016-12-14 19:47 ` Jason A. Donenfeld
2016-12-15 7:57 ` [kernel-hardening] " Herbert Xu
2016-12-15 7:57 ` Herbert Xu
2016-12-15 8:15 ` [kernel-hardening] " Daniel Micay
2016-12-14 12:46 ` Jason A. Donenfeld
2016-12-14 12:46 ` Jason A. Donenfeld
2016-12-14 22:03 ` [kernel-hardening] " Hannes Frederic Sowa
2016-12-14 22:03 ` Hannes Frederic Sowa
2016-12-14 23:29 ` [kernel-hardening] " Jason A. Donenfeld
2016-12-14 23:29 ` Jason A. Donenfeld
2016-12-15 8:31 ` [kernel-hardening] " Hannes Frederic Sowa
2016-12-15 8:31 ` Hannes Frederic Sowa
2016-12-15 11:04 ` [kernel-hardening] " David Laight
2016-12-15 11:04 ` David Laight
2016-12-15 12:23 ` [kernel-hardening] " Hannes Frederic Sowa
2016-12-15 12:23 ` Hannes Frederic Sowa
2016-12-15 12:28 ` [kernel-hardening] " David Laight
2016-12-15 12:28 ` David Laight
2016-12-15 12:50 ` [kernel-hardening] " Hannes Frederic Sowa
2016-12-15 12:50 ` Hannes Frederic Sowa
2016-12-15 13:56 ` [kernel-hardening] " David Laight
2016-12-15 13:56 ` David Laight
2016-12-15 14:56 ` [kernel-hardening] " Hannes Frederic Sowa
2016-12-15 14:56 ` Hannes Frederic Sowa
2016-12-15 15:41 ` [kernel-hardening] " David Laight
2016-12-15 15:41 ` David Laight
2016-12-15 15:53 ` [kernel-hardening] " Hannes Frederic Sowa
2016-12-15 15:53 ` Hannes Frederic Sowa
2016-12-15 18:50 ` [kernel-hardening] " Jason A. Donenfeld
2016-12-15 18:50 ` Jason A. Donenfeld
2016-12-15 20:31 ` [kernel-hardening] " Hannes Frederic Sowa
2016-12-15 20:31 ` Hannes Frederic Sowa
2016-12-15 20:43 ` [kernel-hardening] " Jason A. Donenfeld
2016-12-15 20:43 ` Jason A. Donenfeld
2016-12-15 21:04 ` [kernel-hardening] " Peter Zijlstra
2016-12-15 21:04 ` Peter Zijlstra
2016-12-15 21:09 ` [kernel-hardening] " Hannes Frederic Sowa
2016-12-15 21:09 ` Hannes Frederic Sowa
2016-12-15 21:17 ` [kernel-hardening] " Hannes Frederic Sowa
2016-12-15 21:17 ` Hannes Frederic Sowa
2016-12-15 21:09 ` Peter Zijlstra [this message]
2016-12-15 21:09 ` Peter Zijlstra
2016-12-15 21:11 ` [kernel-hardening] " Jason A. Donenfeld
2016-12-15 21:14 ` Linus Torvalds
2016-12-14 18:46 ` [kernel-hardening] [PATCH v3 1/3] " Jason A. Donenfeld
2016-12-14 18:46 ` Jason A. Donenfeld
2016-12-14 18:46 ` [kernel-hardening] [PATCH v3 2/3] secure_seq: use siphash24 instead of md5_transform Jason A. Donenfeld
2016-12-14 18:46 ` Jason A. Donenfeld
2016-12-14 21:44 ` [kernel-hardening] " kbuild test robot
2016-12-14 21:44 ` kbuild test robot
2016-12-14 18:46 ` [kernel-hardening] [PATCH v3 3/3] random: use siphash24 instead of md5 for get_random_int/long Jason A. Donenfeld
2016-12-14 18:46 ` Jason A. Donenfeld
2016-12-14 21:56 ` [kernel-hardening] " kbuild test robot
2016-12-14 21:56 ` kbuild test robot
2016-12-14 21:57 ` [kernel-hardening] " kbuild test robot
2016-12-14 21:57 ` kbuild test robot
2016-12-15 10:14 ` [kernel-hardening] " David Laight
2016-12-15 10:14 ` David Laight
2016-12-15 18:51 ` [kernel-hardening] " Jason A. Donenfeld
2016-12-15 18:51 ` Jason A. Donenfeld
2016-12-14 19:18 ` [kernel-hardening] Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function Tom Herbert
2016-12-14 19:18 ` Tom Herbert
2016-12-14 19:35 ` [kernel-hardening] " Jason A. Donenfeld
2016-12-14 19:35 ` Jason A. Donenfeld
2016-12-14 20:55 ` [kernel-hardening] " Jason A. Donenfeld
2016-12-14 20:55 ` Jason A. Donenfeld
2016-12-14 21:35 ` [kernel-hardening] " Tom Herbert
2016-12-14 21:35 ` Tom Herbert
2016-12-14 22:56 ` [kernel-hardening] " Jason A. Donenfeld
2016-12-14 22:56 ` Jason A. Donenfeld
2016-12-14 23:14 ` [kernel-hardening] " Tom Herbert
2016-12-14 23:14 ` Tom Herbert
2016-12-14 23:17 ` [kernel-hardening] " Jason A. Donenfeld
2016-12-14 23:17 ` Jason A. Donenfeld
2016-12-18 0:06 ` [kernel-hardening] " Christian Kujau
2016-12-18 0:06 ` Christian Kujau
2016-12-14 23:30 ` [kernel-hardening] " Linus Torvalds
2016-12-14 23:30 ` Linus Torvalds
2016-12-14 23:34 ` [kernel-hardening] " Jason A. Donenfeld
2016-12-14 23:34 ` Jason A. Donenfeld
2016-12-15 0:10 ` [kernel-hardening] " Linus Torvalds
2016-12-15 0:10 ` Linus Torvalds
2016-12-15 10:22 ` [kernel-hardening] " David Laight
2016-12-15 10:22 ` David Laight
2016-12-14 21:15 ` [kernel-hardening] " kbuild test robot
2016-12-14 21:15 ` kbuild test robot
2016-12-14 21:21 ` [kernel-hardening] " Jason A. Donenfeld
2016-12-14 21:21 ` Jason A. Donenfeld
2016-12-15 1:46 ` [kernel-hardening] [PATCH v4 1/4] " Jason A. Donenfeld
2016-12-15 1:46 ` Jason A. Donenfeld
2016-12-15 1:46 ` [kernel-hardening] [PATCH v4 2/4] siphash: add N[qd]word helpers Jason A. Donenfeld
2016-12-15 1:46 ` Jason A. Donenfeld
2016-12-15 1:46 ` [kernel-hardening] [PATCH v4 3/4] secure_seq: use siphash instead of md5_transform Jason A. Donenfeld
2016-12-15 1:46 ` Jason A. Donenfeld
2016-12-15 1:46 ` [kernel-hardening] [PATCH v4 4/4] random: use siphash instead of MD5 for get_random_int/long Jason A. Donenfeld
2016-12-15 1:46 ` Jason A. Donenfeld
2016-12-15 4:23 ` [kernel-hardening] Re: [PATCH v4 1/4] siphash: add cryptographically secure hashtable function kbuild test robot
2016-12-15 4:23 ` kbuild test robot
-- strict thread matches above, loose matches on Subject: below --
2016-12-15 21:16 [kernel-hardening] Re: [PATCH v2 " Jason A. Donenfeld
2016-12-15 21:25 Jason A. Donenfeld
2016-12-15 21:45 ` Hannes Frederic Sowa
2016-12-15 23:43 ` Jason A. Donenfeld
2016-12-16 0:03 ` Hannes Frederic Sowa
2016-12-15 23:47 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161215210933.GY3207@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=David.Laight@aculab.com \
--cc=Jason@zx2c4.com \
--cc=djb@cr.yp.to \
--cc=ebiggers3@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=jeanphilippe.aumasson@gmail.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.