All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 0/2] GTP tunneling fixes for net
Date: Thu, 15 Dec 2016 22:37:38 +0100	[thread overview]
Message-ID: <20161215213738.GA10419@salvia> (raw)
In-Reply-To: <1481837753-10317-1-git-send-email-pablo@netfilter.org>

Sorry for the noise, this is not Netfilter related, my robot has
tricked me, I have fixed it now.

On Thu, Dec 15, 2016 at 10:35:51PM +0100, Pablo Neira Ayuso wrote:
> Hi David,
> 
> The following patchset contains two GTP tunneling fixes for your net
> tree, they are:
> 
> 1) Offset to IPv4 header in gtp_check_src_ms_ipv4() is incorrect, thus
>    this function always succeeds and therefore this defeats this sanity
>    check. This allows packets that have no PDP to go though, patch from
>    Lionel Gauthier.
> 
> 2) According to Note 0 of Figure 2 in Section 6 of 3GPP TS 29.060 v13.5.0
>    Release 13, always set GTPv1 reserved bit to zero. This may cause
>    interoperability problems, patch from Harald Welte.
> 
> Please, apply, thanks a lot!
> 
> Harald Welte (1):
>   gtp: Fix initialization of Flags octet in GTPv1 header
> 
> Lionel Gauthier (1):
>   gtp: gtp_check_src_ms_ipv4() always return success
> 
>  drivers/net/gtp.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> -- 
> 2.1.4
> 

  parent reply	other threads:[~2016-12-15 22:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-15 21:35 [PATCH 0/2] GTP tunneling fixes for net Pablo Neira Ayuso
2016-12-15 21:35 ` [PATCH 1/2] gtp: gtp_check_src_ms_ipv4() always return success Pablo Neira Ayuso
2016-12-15 21:35 ` [PATCH 2/2] gtp: Fix initialization of Flags octet in GTPv1 header Pablo Neira Ayuso
2016-12-15 21:37 ` Pablo Neira Ayuso [this message]
2016-12-17 17:01 ` [PATCH 0/2] GTP tunneling fixes for net David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161215213738.GA10419@salvia \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.